Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: doc/contributing.html

Issue 1232833004: Update findbugs from 3.0.0 to 3.0.1. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/findbugs.git@master
Patch Set: rebase again Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « doc/bugDescriptions_ja.html ('k') | doc/demo.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: doc/contributing.html
diff --git a/doc/contributing.html b/doc/contributing.html
index e2165ce1f1a42ebcb4e0515d5fadacc44f2c9d48..018083f37e787955ce69fcc8e344889c7af9a1af 100644
--- a/doc/contributing.html
+++ b/doc/contributing.html
@@ -42,7 +42,7 @@
<tr><td>&nbsp;</td></tr>
<tr><td><b>Development</b></td></tr>
-<tr><td><font size="-1">&nbsp;<a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1">&nbsp;<a class="sidebar" href="http://sourceforge.net/p/findbugs/bugs/">Open bugs</a></font></td></tr>
<tr><td><font size="-1">&nbsp;<a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
<tr><td><font size="-1">&nbsp;<a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
<tr><td><font size="-1">&nbsp;<a class="sidebar" href="team.html">Dev team</a></font></td></tr>
@@ -74,8 +74,9 @@ here: <a href="https://code.google.com/p/findbugs/source/browse/eclipsePlugin/do
<p> The best way to create a patch is to clone FindBugs Git repository here:
<a href="http://code.google.com/p/findbugs/source/clones">http://code.google.com/p/findbugs/source/clones</a>,
commit changes with descriptive commit messages (small commits are better) and
- create a new <a href="https://sourceforge.net/p/findbugs/patches/">patch ticket</a>
- with the link to your repository.
+ create a new <a href="https://sourceforge.net/p/findbugs/bugs/">bug</a>
+ or <a href="https://sourceforge.net/p/findbugs/feature-requests/">feature request</a>
+ with the "[patch]" prefix in the title and link to your repository in the description.
</p>
<p> Please follow these guidelines when preparing your patch:</p>
@@ -85,18 +86,24 @@ here: <a href="https://code.google.com/p/findbugs/source/browse/eclipsePlugin/do
to indent your code; four spaces per indent level.
<li> If at all possible, avoid making whitespace modifications.
<li> Small patches/changesets are appreciated.
+<li> If you have lot of changes, try to group them by small commits with descriptive messages.
+<li> If you have multiple patches, create <b>branch per patch</b>.
+<li> All new files should contain proper license header (<a href="http://www.gnu.org/licenses/lgpl.html">Lesser GNU Public License</a>).
<li> If you are submitting a new bug detector, please submit a small
standalone source file that contains an instance of the
- kind of bug the detector looks for.
+ kind of bug the detector looks for. The file should be placed at
+ <a href="https://code.google.com/p/findbugs/source/browse/#git%2FfindbugsTestCases%2Fsrc%2Fjava%2FsfBugsNew">findbugsTestCases/src/java/sfBugsNew</a>
+ package and named after the bug or feature you are addressing.
</ul>
<p> Following these guidelines makes it much easier for us
to incorporate new code.
-<h2>How to submit a patch</h2>
+<h2>Where to submit a patch</h2>
<p> Patches may be submitted through the
-<a href="https://sourceforge.net/p/findbugs/patches/">Patches</a> tracker on the
+<a href="https://sourceforge.net/p/findbugs/bugs/">bug</a>
+ or <a href="https://sourceforge.net/p/findbugs/feature-requests/">feature request</a> trackers on the
<a href="http://sourceforge.net/projects/findbugs/">sourceforge project page</a>.
@@ -108,7 +115,7 @@ document.write( "Last updated "+ document.lastModified + "." );
</script>
<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
<p>
-<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&amp;type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
+<a href="http://sourceforge.net/projects/findbugs/"><img src="http://sourceforge.net/sflogo.php?group_id=96405&amp;type=5" width="210" height="62" border="0" alt="FindBugs on SourceForge.net" /></a>
</td>
« no previous file with comments | « doc/bugDescriptions_ja.html ('k') | doc/demo.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698