Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232833002: X87: Remove separate construct stub for new.target users. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove separate construct stub for new.target users. port e50c861b099b3bd3e1174b5f2843567620cc6842 (r29562) original commit message: BUG= Committed: https://crrev.com/f9d435d241593c33153ccef396e406962d2c757a Cr-Commit-Position: refs/heads/master@{#29631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M src/x87/builtins-x87.cc View 9 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-14 01:53:42 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 02:09:55 UTC) #5
Weiliang
lgtm lgtm
5 years, 5 months ago (2015-07-14 02:09:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232833002/1
5 years, 5 months ago (2015-07-14 02:10:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 02:45:36 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:45:55 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f9d435d241593c33153ccef396e406962d2c757a
Cr-Commit-Position: refs/heads/master@{#29631}

Powered by Google App Engine
This is Rietveld 408576698