Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1232823002: Fix keyed stores to strings convertible to indices (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix keyed stores to strings convertible to indices BUG=chromium:509545 LOG=n Committed: https://crrev.com/bb964f63d1443b460c7f2d204ae26fa79d2afe08 Cr-Commit-Position: refs/heads/master@{#29596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/ic/ic.cc View 3 chunks +4 lines, -19 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/primitive-keyed-access.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-13 09:58:34 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-13 10:15:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232823002/1
5 years, 5 months ago (2015-07-13 10:19:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 10:46:32 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 10:46:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb964f63d1443b460c7f2d204ae26fa79d2afe08
Cr-Commit-Position: refs/heads/master@{#29596}

Powered by Google App Engine
This is Rietveld 408576698