Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: src/objects.cc

Issue 12328136: Normalized map copies should not share code caches (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5250 matching lines...) Expand 10 before | Expand all | Expand 10 after
5261 } 5261 }
5262 5262
5263 Map* result; 5263 Map* result;
5264 MaybeObject* maybe_result = RawCopy(new_instance_size); 5264 MaybeObject* maybe_result = RawCopy(new_instance_size);
5265 if (!maybe_result->To(&result)) return maybe_result; 5265 if (!maybe_result->To(&result)) return maybe_result;
5266 5266
5267 if (mode != CLEAR_INOBJECT_PROPERTIES) { 5267 if (mode != CLEAR_INOBJECT_PROPERTIES) {
5268 result->set_inobject_properties(inobject_properties()); 5268 result->set_inobject_properties(inobject_properties());
5269 } 5269 }
5270 5270
5271 result->set_code_cache(code_cache());
5272 result->set_is_shared(sharing == SHARED_NORMALIZED_MAP); 5271 result->set_is_shared(sharing == SHARED_NORMALIZED_MAP);
5273 result->set_dictionary_map(true); 5272 result->set_dictionary_map(true);
5274 5273
5275 #ifdef VERIFY_HEAP 5274 #ifdef VERIFY_HEAP
5276 if (FLAG_verify_heap && result->is_shared()) { 5275 if (FLAG_verify_heap && result->is_shared()) {
5277 result->SharedMapVerify(); 5276 result->SharedMapVerify();
5278 } 5277 }
5279 #endif 5278 #endif
5280 5279
5281 return result; 5280 return result;
(...skipping 8700 matching lines...) Expand 10 before | Expand all | Expand 10 after
13982 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13981 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13983 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13982 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13984 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13983 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13985 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13984 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13986 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13985 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13987 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13986 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13988 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13987 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13989 } 13988 }
13990 13989
13991 } } // namespace v8::internal 13990 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698