tools/dom/src/native_DOMImplementation.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/native_DOMImplementation.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/native_DOMImplementation.dart

diff --git a/tools/dom/src/native_DOMImplementation.dart b/tools/dom/src/native_DOMImplementation.dart

index 2f91ab1af597278ba9cf1d724cd1dcd956ba8b52..84d9af80bdc0582fc8c3e4f1c1ae9dd10b378fef 100644

--- a/tools/dom/src/native_DOMImplementation.dart

+++ b/tools/dom/src/native_DOMImplementation.dart

@@ -8,7 +8,7 @@ class _Utils {

static List convertToList(List list) {

// FIXME: [possible optimization]: do not copy the array if Dart_IsArray is fine w/ it.

final length = list.length;

- List result = new List.fixedLength(length);

+ List result = new List(length);

result.setRange(0, length, list);

return result;

}