sdk/lib/core/string.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/core/string.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/core/string.dart

diff --git a/sdk/lib/core/string.dart b/sdk/lib/core/string.dart

index e08f291d70ff8b0c16e2542f749d7181ccc87144..d780314f2e0a9c59b775303bd0103293a7eca493 100644

--- a/sdk/lib/core/string.dart

+++ b/sdk/lib/core/string.dart

@@ -38,7 +38,7 @@ abstract class String implements Comparable<String>, Pattern {

* one half of a surrogate pair.

factory String.fromCharCode(int charCode) {

- List<int> charCodes = new List<int>.fixedLength(1, fill: charCode);

+ List<int> charCodes = new List<int>.filled(1, charCode);

return new String.fromCharCodes(charCodes);

}