pkg/unittest/lib/src/collection_matchers.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/src/collection_matchers.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/unittest/lib/src/collection_matchers.dart

diff --git a/pkg/unittest/lib/src/collection_matchers.dart b/pkg/unittest/lib/src/collection_matchers.dart

index 80ac42811de4ba2f78dd41ffa47abf819b0fb2af..30e38f6bf95e1867900668de1086be4647d74eb0 100644

--- a/pkg/unittest/lib/src/collection_matchers.dart

+++ b/pkg/unittest/lib/src/collection_matchers.dart

@@ -142,7 +142,7 @@ class _UnorderedEquals extends BaseMatcher {

} else if (expectedLength < actualLength) {

return 'has too many elements (${actualLength} > ${expectedLength})';

}

- List<bool> matched = new List<bool>.fixedLength(actualLength);

+ List<bool> matched = new List<bool>(actualLength);

for (var i = 0; i < actualLength; i++) {

matched[i] = false;

}