sdk/lib/_internal/compiler/implementation/util/link_implementation.dart - Issue 12328104: Change new List(n) to return fixed length list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/util/link_implementation.dart

Issue 12328104: Change new List(n) to return fixed length list. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('K') | « sdk/lib/_internal/compiler/implementation/util/link.dart ('k') | sdk/lib/async/future_impl.dart » ('j') | sdk/lib/core/list.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/util/link_implementation.dart

diff --git a/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart b/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart

index 2f9ea8414d63179db530781e952811e3671e5790..65358c6c4a3320db9d8bca23232da911aec43eb4 100644

--- a/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart

+++ b/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart

@@ -81,11 +81,14 @@ class LinkEntry<T> extends Link<T> {

bool get isEmpty => false;

- List<T> toList() {

+ List<T> toList({ bool growable: false }) {

floitsch 2013/02/26 13:54:19 => new List<T>.from(this, growable: growable);

Lasse Reichstein Nielsen 2013/02/26 15:26:00 Done.

List<T> list = new List<T>();

for (Link<T> link = this; !link.isEmpty; link = link.tail) {

list.addLast(link.head);

}

+ if (!growable) {

+ list = new List<T>.from(list);

+ }

return list;

}