Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ElementMap.java

Issue 12328102: Update dartc tests and services_test plugins to run from the buildbot_test plugin. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/ElementMap.java
===================================================================
--- compiler/java/com/google/dart/compiler/resolver/ElementMap.java (revision 19029)
+++ compiler/java/com/google/dart/compiler/resolver/ElementMap.java (working copy)
@@ -4,8 +4,9 @@
package com.google.dart.compiler.resolver;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.dart.compiler.ast.DartNode;
import com.google.dart.compiler.ast.DartObsoleteMetadata;
-import com.google.dart.compiler.ast.DartNode;
import com.google.dart.compiler.ast.Modifiers;
import com.google.dart.compiler.common.SourceInfo;
import com.google.dart.compiler.type.Type;
@@ -17,7 +18,8 @@
* A more efficient version of {@link com.google.common.collect.Multimap} specifically for
* {@link NodeElement}
*/
-class ElementMap {
+@VisibleForTesting
+public class ElementMap {
/**
* A synthetic place holder for an element where the name given to the element map does not match
@@ -98,7 +100,8 @@
private NodeElement[] elements;
private List<NodeElement> ordered = new ArrayList<NodeElement>();
- ElementMap() {
+ @VisibleForTesting
+ public ElementMap() {
clear();
}
@@ -106,7 +109,8 @@
* Associate the specified element with the specified name. If the element is already associated
* with that name, do not associate it again.
*/
- void add(String name, NodeElement element) {
+ @VisibleForTesting
+ public void add(String name, NodeElement element) {
// Most of the time name equals getName() thus holder == element
NodeElement newHolder;
@@ -161,7 +165,8 @@
*
* @return the element or <code>null</code> if none
*/
- NodeElement get(String name) {
+ @VisibleForTesting
+ public NodeElement get(String name) {
NodeElement element = internalGet(name);
if (element instanceof ElementHolder) {
return ((ElementHolder) element).element;
@@ -175,7 +180,8 @@
*
* @return the element of that kind or <code>null</code> if none
*/
- NodeElement get(String name, ElementKind kind) {
+ @VisibleForTesting
+ public NodeElement get(String name, ElementKind kind) {
NodeElement element = internalGet(name);
if (element instanceof ElementHolder) {
ElementHolder holder = (ElementHolder) element;
@@ -197,15 +203,18 @@
return null;
}
- boolean isEmpty() {
+ @VisibleForTesting
+ public boolean isEmpty() {
return ordered.isEmpty();
}
- int size() {
+ @VisibleForTesting
+ public int size() {
return ordered.size();
}
- List<NodeElement> values() {
+ @VisibleForTesting
+ public List<NodeElement> values() {
return ordered;
}

Powered by Google App Engine
This is Rietveld 408576698