Chromium Code Reviews Chromium Code Reviews
Issue
12328080:
Plumb physical backing size from RWHV to renderer CC. (Closed)
DescriptionPlumb physical backing size from RWHV to renderer CC.
This patch introduces a concept of "physical backing size" which is plumbed
down from port-specific browser code to the renderer compositor.
This is distinct from the usual concept of view size on high-DPI screens
with >1 dpi scale. Physical backing size represents the size of the
texture CC draws to, whereas the view size is given to WebKit and
specifies the CSS width/height.
Before this patch, physical backing size was recalculated in the
renderer by multiplying the view size by DPI scale. There are two problems
with this:
- This introduces off-by-one errors when DPI scale is non-integral.
Values such as 1.5 and 1.33125 are common on Android devices.
- The Android port would like to more efficiently implement features like
on-screen-keyboard bringup and URL-bar hiding without needing to
resize the backing texture. Separating the value given to CC and to
WebKit is the first step towards this.
WebKit counterpart at https://bugs.webkit.org/show_bug.cgi?id=110727
NOTRY=true
BUG=152502
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185621
Patch Set 1 #Patch Set 2 : Switch to ViewMsg_Resize #Patch Set 3 : Fix render_view_test.cc compile #Patch Set 4 : Fix RenderWidgetFullscreenPepper #Patch Set 5 : Fetch device scale directly in RWVHBase #
Total comments: 1
Patch Set 6 : Check if(compositor_) and use physical_backing_size with fullscreen pepper #Patch Set 7 : Also set viewport size in initializeLayerTreeView #Patch Set 8 : Adjust for call renamed to GetViewportSizePix() #Messages
Total messages: 13 (0 generated)
|
