Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12328080: Plumb physical backing size from RWHV to renderer CC. (Closed)

Created:
7 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 9 months ago
Reviewers:
palmer, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jamesr, Ted C, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Plumb physical backing size from RWHV to renderer CC. This patch introduces a concept of "physical backing size" which is plumbed down from port-specific browser code to the renderer compositor. This is distinct from the usual concept of view size on high-DPI screens with >1 dpi scale. Physical backing size represents the size of the texture CC draws to, whereas the view size is given to WebKit and specifies the CSS width/height. Before this patch, physical backing size was recalculated in the renderer by multiplying the view size by DPI scale. There are two problems with this: - This introduces off-by-one errors when DPI scale is non-integral. Values such as 1.5 and 1.33125 are common on Android devices. - The Android port would like to more efficiently implement features like on-screen-keyboard bringup and URL-bar hiding without needing to resize the backing texture. Separating the value given to CC and to WebKit is the first step towards this. WebKit counterpart at https://bugs.webkit.org/show_bug.cgi?id=110727 NOTRY=true BUG=152502 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185621

Patch Set 1 #

Patch Set 2 : Switch to ViewMsg_Resize #

Patch Set 3 : Fix render_view_test.cc compile #

Patch Set 4 : Fix RenderWidgetFullscreenPepper #

Patch Set 5 : Fetch device scale directly in RWVHBase #

Total comments: 1

Patch Set 6 : Check if(compositor_) and use physical_backing_size with fullscreen pepper #

Patch Set 7 : Also set viewport size in initializeLayerTreeView #

Patch Set 8 : Adjust for call renamed to GetViewportSizePix() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -23 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 6 7 1 chunk +12 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 4 3 chunks +17 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 7 4 chunks +9 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 3 4 5 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
aelias_OOO_until_Jul13
Hi Antoine, PTAL. Note that I first considered adding a field to ViewMsg_Resize, but this ...
7 years, 10 months ago (2013-02-25 07:35:44 UTC) #1
piman
On 2013/02/25 07:35:44, aelias wrote: > Hi Antoine, PTAL. Note that I first considered adding ...
7 years, 9 months ago (2013-02-25 21:48:16 UTC) #2
palmer
lgtm
7 years, 9 months ago (2013-02-25 23:17:11 UTC) #3
aelias_OOO_until_Jul13
OK, I wanted to avoid messing with the legacy software path but that just made ...
7 years, 9 months ago (2013-02-27 05:45:32 UTC) #4
piman
lgtm https://codereview.chromium.org/12328080/diff/12016/content/renderer/render_widget_fullscreen_pepper.cc File content/renderer/render_widget_fullscreen_pepper.cc (right): https://codereview.chromium.org/12328080/diff/12016/content/renderer/render_widget_fullscreen_pepper.cc#newcode526 content/renderer/render_widget_fullscreen_pepper.cc:526: // FIXME: Try using physical_backing_size here instead of ...
7 years, 9 months ago (2013-02-27 08:12:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12328080/13001
7 years, 9 months ago (2013-02-28 08:20:12 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 9 months ago (2013-02-28 09:46:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12328080/23001
7 years, 9 months ago (2013-03-01 05:32:54 UTC) #8
commit-bot: I haz the power
Change committed as 185475
7 years, 9 months ago (2013-03-01 07:21:21 UTC) #9
jln (very slow on Chromium)
On 2013/03/01 07:21:21, I haz the power (commit-bot) wrote: > Change committed as 185475 Sorry, ...
7 years, 9 months ago (2013-03-01 07:41:14 UTC) #10
aelias_OOO_until_Jul13
The problem was a function rename that hadn't gotten pulled into LKGR yet. Trybots look ...
7 years, 9 months ago (2013-03-01 23:35:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12328080/22002
7 years, 9 months ago (2013-03-01 23:37:27 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-01 23:42:46 UTC) #13
Message was sent while issue was closed.
Change committed as 185621

Powered by Google App Engine
This is Rietveld 408576698