net/url_request/url_request_job_factory_impl_unittest.cc - Issue 12328072: Remove some calls to URLRequestContext::network_delegate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_job_factory_impl_unittest.cc

Issue 12328072: Remove some calls to URLRequestContext::network_delegate(). (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Provide read-only access to network delegate for derived classes. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_job_factory_impl_unittest.cc

diff --git a/net/url_request/url_request_job_factory_impl_unittest.cc b/net/url_request/url_request_job_factory_impl_unittest.cc

index 5f0e16c36e54f1a461c9867ea2d5734d008d1067..e03668a934c6a60226463db6c07da841e18d0c5a 100644

--- a/net/url_request/url_request_job_factory_impl_unittest.cc

+++ b/net/url_request/url_request_job_factory_impl_unittest.cc

@@ -60,7 +60,7 @@ class DummyProtocolHandler : public URLRequestJobFactory::ProtocolHandler {

TEST(URLRequestJobFactoryTest, NoProtocolHandler) {

TestDelegate delegate;

TestURLRequestContext request_context;

- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);

+ TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);

request.Start();

MessageLoop::current()->Run();

@@ -74,7 +74,7 @@ TEST(URLRequestJobFactoryTest, BasicProtocolHandler) {

TestURLRequestContext request_context;

request_context.set_job_factory(&job_factory);

job_factory.SetProtocolHandler("foo", new DummyProtocolHandler);

- TestURLRequest request(GURL("foo://bar"), &delegate, &request_context);

+ TestURLRequest request(GURL("foo://bar"), &delegate, &request_context, NULL);

request.Start();

MessageLoop::current()->Run();

« no previous file with comments | « net/url_request/url_request_job.h ('k') | net/url_request/url_request_job_unittest.cc » ('j') | no next file with comments »