Fix prefs registration for BrowserInstantController.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 149 matching lines @@
           this.setDefaultSearchEngine_);
       if (loadTimeData.getValue('instant_enabled') ==
           'instant_extended.enabled') {
         // We don't want to see the confirm dialog for instant extended.
         $('instant-enabled-control').removeAttribute('dialog-pref');
         $('instant-enabled-indicator').removeAttribute('dialog-pref');
         // And we want to upload a different metric name.
         $('instant-enabled-control').setAttribute(
             'metric', 'Options_InstantExtendedEnabled');
       }
+      // We need to set the starting value for the instant checkbox as
+      // it may be different from the value of the preference.

[Mattias Nissler (ping if slow), 2013/02/25 18:53:41]

If the instant_enabled is set to the right pref name, the UI should do the right
thing already if I'm not mistaken. See
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

+      if (loadTimeData.getValue('instant_starting_value')) {
+        $('instant-enabled-control').setAttribute('checked', 'true');
+      } else {
+        $('instant-enabled-control').setAttribute('checked', 'false');
+      }
 
       // Users section.
       if (loadTimeData.valueExists('profilesInfo')) {
         $('profiles-section').hidden = false;
 
         var profilesList = $('profiles-list');
         options.browser_options.ProfileList.decorate(profilesList);
         profilesList.autoExpands = true;
 
         this.setProfilesInfo_(loadTimeData.getValue('profilesInfo'));
@@ skipping 1240 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });