Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/JavascriptVmFactory.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/JavascriptVmFactory.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/JavascriptVmFactory.java
similarity index 64%
rename from plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java
rename to plugins/org.chromium.sdk/src/org/chromium/sdk/JavascriptVmFactory.java
index dc6cc362cc4ef969d46dbf10e7b6d63d244c255a..3f76120cfcd32481fbe2525d5eaff8e3b2003f8c 100755
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/JavascriptVmFactory.java
@@ -7,22 +7,24 @@ package org.chromium.sdk;
import java.net.SocketAddress;
import java.util.logging.Logger;
-import org.chromium.sdk.internal.BrowserFactoryImpl;
+import org.chromium.sdk.internal.JavascriptVmFactoryImpl;
+import org.chromium.sdk.wip.WipBrowser;
+import org.chromium.sdk.wip.WipBrowserFactory;
/**
- * A factory for Browser instances.
- * TODO: reflect that it only creates standalone client, no browser.
+ * A factory for {@link JavascriptVm} instances. Note that {@link WipBrowser} instances are
+ * created in a specialized class {@link WipBrowserFactory}.
*/
-public abstract class BrowserFactory {
+public abstract class JavascriptVmFactory {
/**
- * Gets a {@link BrowserFactory} instance. This method should be overridden by
+ * Gets a {@link JavascriptVmFactory} instance. This method should be overridden by
* implementations that want to construct other implementations of
* {@link Browser}.
*
- * @return a BrowserFactory singleton instance
+ * @return a {@link JavascriptVmFactory} singleton instance
*/
- public static BrowserFactory getInstance() {
- return BrowserFactoryImpl.INSTANCE;
+ public static JavascriptVmFactory getInstance() {
+ return JavascriptVmFactoryImpl.INSTANCE;
}
/**

Powered by Google App Engine
This is Rietveld 408576698