plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java - Issue 12328046: Fullfill couple of TODOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java ('k') | plugins/org.chromium.sdk.tests/src/org/chromium/sdk/internal/BrowserFactoryImplTestGate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java

diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java

index 5613aba02e963b7a8928b6e66ee7128e5f011622..c78309cc96f049ab86fdb5031a24ec6568cbf13a 100644

--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java

+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/JavascriptVmEmbedderFactory.java

@@ -18,7 +18,7 @@ import java.util.List;

import org.chromium.debug.core.ChromiumDebugPlugin;

import org.chromium.debug.core.ScriptNameManipulator;

import org.chromium.debug.core.util.JavaScriptRegExpSupport;

-import org.chromium.sdk.BrowserFactory;

+import org.chromium.sdk.JavascriptVmFactory;

import org.chromium.sdk.ConnectionLogger;

import org.chromium.sdk.DebugEventListener;

import org.chromium.sdk.JavascriptVm;

@@ -191,7 +191,7 @@ public class JavascriptVmEmbedderFactory {

SocketAddress address = new InetSocketAddress(host, port);

ConnectionLogger connectionLogger =

connectionLoggerFactory.createLogger(address.toString());

- final StandaloneVm standaloneVm = BrowserFactory.getInstance().createStandalone(address,

+ final StandaloneVm standaloneVm = JavascriptVmFactory.getInstance().createStandalone(address,

connectionLogger);

return new JavascriptVmEmbedder.ConnectionToRemote() {