Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java
deleted file mode 100755
index 8c3eac0070b86718018f5a0a321a3bc65f45dad4..0000000000000000000000000000000000000000
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java
+++ /dev/null
@@ -1,54 +0,0 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.sdk.internal;
-
-import java.net.SocketAddress;
-
-import org.chromium.sdk.BrowserFactory;
-import org.chromium.sdk.ConnectionLogger;
-import org.chromium.sdk.StandaloneVm;
-import org.chromium.sdk.internal.standalonev8.StandaloneVmImpl;
-import org.chromium.sdk.internal.transport.Connection;
-import org.chromium.sdk.internal.transport.Handshaker;
-import org.chromium.sdk.internal.transport.SocketConnection;
-
-/**
- * A default implementation of the BrowserFactory interface.
- * TODO: rename it somehow. It's not only a browser factory.
- */
-public class BrowserFactoryImpl extends BrowserFactory {
-
- public static final BrowserFactoryImpl INSTANCE = new BrowserFactoryImpl();
-
- private static final int DEFAULT_CONNECTION_TIMEOUT_MS = 1000;
-
- @Override
- public StandaloneVm createStandalone(SocketAddress socketAddress,
- ConnectionLogger connectionLogger) {
- Handshaker.StandaloneV8 handshaker = new Handshaker.StandaloneV8Impl();
- SocketConnection connection =
- new SocketConnection(socketAddress, getTimeout(), connectionLogger, handshaker);
- return createStandalone(connection, handshaker);
- }
-
- // Debug entry (no logger by definition)
- StandaloneVmImpl createStandalone(Connection connection, Handshaker.StandaloneV8 handshaker) {
- return new StandaloneVmImpl(connection, handshaker);
- }
-
- private int getTimeout() {
- String timeoutString = System.getProperty(
- "org.chromium.sdk.client.connection.timeoutMs",
- String.valueOf(DEFAULT_CONNECTION_TIMEOUT_MS));
- int timeoutMs = DEFAULT_CONNECTION_TIMEOUT_MS;
- try {
- timeoutMs = Integer.parseInt(timeoutString);
- } catch (NumberFormatException e) {
- // fall through and use the default value
- }
- return timeoutMs;
- }
-
-}

Powered by Google App Engine
This is Rietveld 408576698