Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java
deleted file mode 100755
index dc6cc362cc4ef969d46dbf10e7b6d63d244c255a..0000000000000000000000000000000000000000
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/BrowserFactory.java
+++ /dev/null
@@ -1,46 +0,0 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.sdk;
-
-import java.net.SocketAddress;
-import java.util.logging.Logger;
-
-import org.chromium.sdk.internal.BrowserFactoryImpl;
-
-/**
- * A factory for Browser instances.
- * TODO: reflect that it only creates standalone client, no browser.
- */
-public abstract class BrowserFactory {
- /**
- * Gets a {@link BrowserFactory} instance. This method should be overridden by
- * implementations that want to construct other implementations of
- * {@link Browser}.
- *
- * @return a BrowserFactory singleton instance
- */
- public static BrowserFactory getInstance() {
- return BrowserFactoryImpl.INSTANCE;
- }
-
- /**
- * Constructs StandaloneVm instance that talks to a V8 JavaScript VM via
- * DebuggerAgent opened at {@code socketAddress}.
- * @param socketAddress V8 DebuggerAgent is listening on
- * @param connectionLogger provides facility for listening to network
- * traffic; may be null
- */
- public abstract StandaloneVm createStandalone(SocketAddress socketAddress,
- ConnectionLogger connectionLogger);
-
- /**
- * @return SDK root logger that can be used to add handlers or to adjust log level
- */
- public static Logger getRootLogger() {
- return LOGGER;
- }
-
- private static final Logger LOGGER = Logger.getLogger("org.chromium.sdk");
-}

Powered by Google App Engine
This is Rietveld 408576698