Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmFactoryImpl.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.sdk.internal; 5 package org.chromium.sdk.internal;
6 6
7 import java.net.SocketAddress; 7 import java.net.SocketAddress;
8 8
9 import org.chromium.sdk.BrowserFactory; 9 import org.chromium.sdk.JavascriptVmFactory;
10 import org.chromium.sdk.ConnectionLogger; 10 import org.chromium.sdk.ConnectionLogger;
11 import org.chromium.sdk.StandaloneVm; 11 import org.chromium.sdk.StandaloneVm;
12 import org.chromium.sdk.internal.standalonev8.StandaloneVmImpl; 12 import org.chromium.sdk.internal.standalonev8.StandaloneVmImpl;
13 import org.chromium.sdk.internal.transport.Connection; 13 import org.chromium.sdk.internal.transport.Connection;
14 import org.chromium.sdk.internal.transport.Handshaker; 14 import org.chromium.sdk.internal.transport.Handshaker;
15 import org.chromium.sdk.internal.transport.SocketConnection; 15 import org.chromium.sdk.internal.transport.SocketConnection;
16 16
17 /** 17 /**
18 * A default implementation of the BrowserFactory interface. 18 * A default implementation of the BrowserFactory interface.
19 * TODO: rename it somehow. It's not only a browser factory. 19 * TODO: rename it somehow. It's not only a browser factory.
20 */ 20 */
21 public class BrowserFactoryImpl extends BrowserFactory { 21 public class JavascriptVmFactoryImpl extends JavascriptVmFactory {
22 22
23 public static final BrowserFactoryImpl INSTANCE = new BrowserFactoryImpl(); 23 public static final JavascriptVmFactoryImpl INSTANCE = new JavascriptVmFactory Impl();
24 24
25 private static final int DEFAULT_CONNECTION_TIMEOUT_MS = 1000; 25 private static final int DEFAULT_CONNECTION_TIMEOUT_MS = 1000;
26 26
27 @Override 27 @Override
28 public StandaloneVm createStandalone(SocketAddress socketAddress, 28 public StandaloneVm createStandalone(SocketAddress socketAddress,
29 ConnectionLogger connectionLogger) { 29 ConnectionLogger connectionLogger) {
30 Handshaker.StandaloneV8 handshaker = new Handshaker.StandaloneV8Impl(); 30 Handshaker.StandaloneV8 handshaker = new Handshaker.StandaloneV8Impl();
31 SocketConnection connection = 31 SocketConnection connection =
32 new SocketConnection(socketAddress, getTimeout(), connectionLogger, hand shaker); 32 new SocketConnection(socketAddress, getTimeout(), connectionLogger, hand shaker);
33 return createStandalone(connection, handshaker); 33 return createStandalone(connection, handshaker);
(...skipping 11 matching lines...) Expand all
45 int timeoutMs = DEFAULT_CONNECTION_TIMEOUT_MS; 45 int timeoutMs = DEFAULT_CONNECTION_TIMEOUT_MS;
46 try { 46 try {
47 timeoutMs = Integer.parseInt(timeoutString); 47 timeoutMs = Integer.parseInt(timeoutString);
48 } catch (NumberFormatException e) { 48 } catch (NumberFormatException e) {
49 // fall through and use the default value 49 // fall through and use the default value
50 } 50 }
51 return timeoutMs; 51 return timeoutMs;
52 } 52 }
53 53
54 } 54 }
OLDNEW
« no previous file with comments | « plugins/org.chromium.sdk/src/org/chromium/sdk/internal/BrowserFactoryImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698