plugins/org.chromium.sdk.tests/src/org/chromium/sdk/internal/BrowserFactoryImplTestGate.java - Issue 12328046: Fullfill couple of TODOs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: plugins/org.chromium.sdk.tests/src/org/chromium/sdk/internal/BrowserFactoryImplTestGate.java

Issue 12328046: Fullfill couple of TODOs (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 package org.chromium.sdk.internal;	1 package org.chromium.sdk.internal;

2	2

3 import org.chromium.sdk.internal.standalonev8.StandaloneVmImpl;	3 import org.chromium.sdk.internal.standalonev8.StandaloneVmImpl;

4 import org.chromium.sdk.internal.transport.Connection;	4 import org.chromium.sdk.internal.transport.Connection;

5 import org.chromium.sdk.internal.transport.Handshaker;	5 import org.chromium.sdk.internal.transport.Handshaker;

6	6

7 public class BrowserFactoryImplTestGate {	7 public class BrowserFactoryImplTestGate {

8 public static StandaloneVmImpl createStandalone(Connection connection,	8 public static StandaloneVmImpl createStandalone(Connection connection,

9 Handshaker.StandaloneV8 handshaker) {	9 Handshaker.StandaloneV8 handshaker) {

10 return BrowserFactoryImpl.INSTANCE.createStandalone(connection, handshaker);	10 return JavascriptVmFactoryImpl.INSTANCE.createStandalone(connection, handsha ker);

11 }	11 }

12 }	12 }

OLD	NEW