Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 12328038: Add a white Default-568h@2x.png placeholder in iOS unit tests bundles. (Closed)

Created:
7 years, 10 months ago by lliabraa
Modified:
7 years, 10 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, lpromero
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a white Default-568h@2x.png placeholder in iOS unit tests bundles. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
M testing/gtest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A testing/gtest_ios/Default-568h@2x.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lliabraa
7 years, 10 months ago (2013-02-21 16:35:02 UTC) #1
stuartmorgan
LGTM
7 years, 10 months ago (2013-02-21 17:30:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/12328038/1
7 years, 10 months ago (2013-02-21 17:33:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 12328038-1 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 10 months ago (2013-02-21 17:33:11 UTC) #4
lliabraa
7 years, 10 months ago (2013-02-21 18:40:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r183839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698