Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1232803005: Add test case for parsing endobj keywords. (Closed)

Created:
5 years, 5 months ago by Tom Sepez
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test case for parsing endobj keywords. There is no assurance that the expected result files are consistent with other readers. Jun will have to verify that after making his parser changes for bug 493126. BUG=493126 R=thestig@chromium.org, jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/5bd88ec07e79215400777f3095c6843e0627cade

Patch Set 1 #

Patch Set 2 : Added a few more tests. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -119 lines) Patch
A + testing/resources/pixel/endobj1.in View 1 chunk +7 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj1.pdf View 2 chunks +9 lines, -5 lines 0 comments Download
A + testing/resources/pixel/endobj10.in View 1 chunk +7 lines, -4 lines 0 comments Download
A + testing/resources/pixel/endobj10.pdf View 2 chunks +9 lines, -6 lines 1 comment Download
A testing/resources/pixel/endobj10_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj11.in View 1 1 chunk +12 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj11.pdf View 1 2 chunks +14 lines, -5 lines 0 comments Download
A testing/resources/pixel/endobj11_expected.pdf.0.png View 1 Binary file 0 comments Download
A + testing/resources/pixel/endobj12.in View 1 1 chunk +12 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj12.pdf View 1 2 chunks +14 lines, -5 lines 0 comments Download
A testing/resources/pixel/endobj12_expected.pdf.0.png View 1 Binary file 0 comments Download
A + testing/resources/pixel/endobj13.in View 1 1 chunk +12 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj13.pdf View 1 2 chunks +14 lines, -5 lines 0 comments Download
A testing/resources/pixel/endobj13_expected.pdf.0.png View 1 Binary file 0 comments Download
A testing/resources/pixel/endobj1_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj2.in View 1 chunk +8 lines, -5 lines 0 comments Download
A + testing/resources/pixel/endobj2.pdf View 2 chunks +10 lines, -7 lines 0 comments Download
A testing/resources/pixel/endobj2_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj3.in View 1 chunk +8 lines, -5 lines 0 comments Download
A + testing/resources/pixel/endobj3.pdf View 2 chunks +10 lines, -7 lines 0 comments Download
A testing/resources/pixel/endobj3_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj4.in View 1 chunk +8 lines, -5 lines 0 comments Download
A + testing/resources/pixel/endobj4.pdf View 2 chunks +9 lines, -6 lines 0 comments Download
A testing/resources/pixel/endobj4_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj5.in View 1 chunk +7 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj5.pdf View 2 chunks +9 lines, -5 lines 0 comments Download
A testing/resources/pixel/endobj5_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj6.in View 1 chunk +7 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj6.pdf View 2 chunks +9 lines, -5 lines 0 comments Download
A testing/resources/pixel/endobj6_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj7.in View 1 chunk +8 lines, -4 lines 0 comments Download
A + testing/resources/pixel/endobj7.pdf View 2 chunks +10 lines, -6 lines 0 comments Download
A testing/resources/pixel/endobj7_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj8.in View 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj8.pdf View 2 chunks +8 lines, -5 lines 1 comment Download
A testing/resources/pixel/endobj8_expected.pdf.0.png View Binary file 0 comments Download
A + testing/resources/pixel/endobj9.in View 1 chunk +6 lines, -3 lines 0 comments Download
A + testing/resources/pixel/endobj9.pdf View 2 chunks +8 lines, -5 lines 1 comment Download
A testing/resources/pixel/endobj9_expected.pdf.0.png View Binary file 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Jun, for review. These are the cases I'd like to cover for your forthcoming stream ...
5 years, 5 months ago (2015-07-13 19:37:48 UTC) #2
Lei Zhang
lgtm but the BUG= line is wrong.
5 years, 5 months ago (2015-07-15 01:50:15 UTC) #3
Tom Sepez
On 2015/07/15 01:50:15, Lei Zhang wrote: > lgtm but the BUG= line is wrong. Nice ...
5 years, 5 months ago (2015-07-15 17:00:48 UTC) #4
Tom Sepez
Committed patchset #2 (id:20001) manually as 5bd88ec07e79215400777f3095c6843e0627cade (presubmit successful).
5 years, 5 months ago (2015-07-15 17:01:34 UTC) #5
jun_fang
5 years, 5 months ago (2015-07-15 18:37:48 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/endobj10.pdf (right):

https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
testing/resources/pixel/endobj10.pdf:42: /Length 97
length should be 93, right? please double check it. thx.

https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/endobj8.pdf (right):

https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
testing/resources/pixel/endobj8.pdf:40: %   keywords to trip us up.  Should only
render |endobj| as text.
Why isn't |endstream| rendered in this case? The end of stream is at line 52.

https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
File testing/resources/pixel/endobj9.pdf (right):

https://codereview.chromium.org/1232803005/diff/20001/testing/resources/pixel...
testing/resources/pixel/endobj9.pdf:40: %   keyword to trip us up.  Should
render nothing as text.
Why? I think that both of them should be rendered. Maybe something I didn't
consider.

Powered by Google App Engine
This is Rietveld 408576698