Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1232803003: Revert of Update V8 DEPS. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Update V8 DEPS. (patchset #3 id:40001 of https://codereview.chromium.org/1232583002/) Reason for revert: [Sheriff] Looks like another clang option got deprecated: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/326 Original issue's description: > Update V8 DEPS. > > Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c > > Original CL: https://codereview.chromium.org/1232043002/ > > BUG= > > Committed: https://crrev.com/6211e1660492f653d30ddd1336bce6f9083ede94 > Cr-Commit-Position: refs/heads/master@{#29598} TBR=jochen@chromium.org,akos.palfi@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c59fdf929c82e270e33dd76fcd66ca7b1b42bb94 Cr-Commit-Position: refs/heads/master@{#29600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Update V8 DEPS.
5 years, 5 months ago (2015-07-13 11:45:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232803003/1
5 years, 5 months ago (2015-07-13 11:45:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 11:45:22 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c59fdf929c82e270e33dd76fcd66ca7b1b42bb94 Cr-Commit-Position: refs/heads/master@{#29600}
5 years, 5 months ago (2015-07-13 11:45:39 UTC) #4
Michael Achenbach
5 years, 5 months ago (2015-07-13 12:04:25 UTC) #5
Message was sent while issue was closed.
Same problem caused by the original clang roll on chromium:
https://codereview.chromium.org/1229653005/

Powered by Google App Engine
This is Rietveld 408576698