Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: net/quic/quic_connection_test.cc

Issue 1232793004: relnote: Deprecate FLAGS_quic_dont_ack_acks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Convert_map_into_list_97162517
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection_test.cc
diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc
index 683385fdbe643fd4dcef02611695ac1af40ff104..946cea95f82b37bbd0aefd8b4d2a99f3e66c6355 100644
--- a/net/quic/quic_connection_test.cc
+++ b/net/quic/quic_connection_test.cc
@@ -1264,7 +1264,6 @@ TEST_P(QuicConnectionTest, OutOfOrderReceiptCausesAckSend) {
}
TEST_P(QuicConnectionTest, OutOfOrderAckReceiptCausesNoAck) {
- ValueRestore<bool> old_flag(&FLAGS_quic_dont_ack_acks, true);
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
SendStreamDataToPeer(1, "foo", 0, !kFin, nullptr);
@@ -1283,26 +1282,6 @@ TEST_P(QuicConnectionTest, OutOfOrderAckReceiptCausesNoAck) {
EXPECT_EQ(2u, writer_->packets_write_attempts());
}
-TEST_P(QuicConnectionTest, OutOfOrderAckReceiptCausesOneAck) {
- ValueRestore<bool> old_flag(&FLAGS_quic_dont_ack_acks, false);
- EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
-
- SendStreamDataToPeer(1, "foo", 0, !kFin, nullptr);
- SendStreamDataToPeer(1, "bar", 3, !kFin, nullptr);
- EXPECT_EQ(2u, writer_->packets_write_attempts());
-
- QuicAckFrame ack1 = InitAckFrame(1);
- QuicAckFrame ack2 = InitAckFrame(2);
- EXPECT_CALL(*send_algorithm_, OnCongestionEvent(true, _, _, _));
- ProcessAckPacket(2, &ack2);
- // Should ack immediately since we have missing packets.
- EXPECT_EQ(3u, writer_->packets_write_attempts());
-
- ProcessAckPacket(1, &ack1);
- // Should not ack an ack filling a missing packet.
- EXPECT_EQ(3u, writer_->packets_write_attempts());
-}
-
TEST_P(QuicConnectionTest, AckReceiptCausesAckSend) {
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698