Chromium Code Reviews Chromium Code Reviews
Issue
1232733002:
DevTools: [network] Show request Start time in timing table (Closed)
DescriptionDevTools: [network] Show request Start time in timing table
The start time was present a few months back but was removed in https://codereview.chromium.org/837553007 . Regardless, I find myself wanting this data on a regular basis to better understand the delta between two requests, as well as the delay until certain key requests like webfonts.
I've fixed the calculation to avoid the -1ms we had previously (screenshot of timing table from Jan 8th source: http://i.imgur.com/LHxYDMA.png )
The reason we got a -1 is the NetworkPanel's calculator has a minimumBoundary that was defined by the "requestWillBeSent" start timestamp (#1).
However once the request is sent, the startTime of the request is updated (#2), however the bounds of the network waterfall were defined by the #2 time, but the request.startTime we have been using is actually the request.issueTime which is #1.
As a result, about a millisecond of ambiguous "queueing" time snuck in there. This time is explained by this comment. https://code.google.com/p/chromium/issues/detail?id=476749#c11
This CL also updates the definition of "start" to be request.startTime rather than request.issueTime, which is a more logical representation. As such, queuing time occurs before the request's start, and so it's bar has flipped against the start line.
Screenshot: http://i.imgur.com/eQN2h4R.png
BUG=447200, 476749
Patch Set 1 #Patch Set 2 : Queueing flipped in table, total time doesn't include queuing. #Patch Set 3 : rebase on top of https://codereview.chromium.org/1266713008/ #Patch Set 4 : ya #Patch Set 5 : post-fork. queuing is inside of total. queued time, too #
Messages
Total messages: 9 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
