Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1232723002: win/clang: Remove unused variables in 32-bit builds. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/clang: Remove unused variables in 32-bit builds. No inteded behavior change. Fixes: ..\..\sandbox\win\src\process_mitigations.cc(90,24) : warning(clang): unused variable 'MEM_EXECUTE_OPTION_ENABLE' [-Wunused-variable] static const int MEM_EXECUTE_OPTION_ENABLE = 1; ^ ..\..\sandbox\win\src\service_resolver_32.cc(21,12) : warning(clang): unused variable 'kNop' [-Wunused-const-variable] const BYTE kNop = 0x90; ^ ..\..\sandbox\win\src\service_resolver_32.cc(33,11) : warning(clang): unused variable 'kMaxService' [-Wunused-const-variable] const int kMaxService = 1000; ^ BUG=505319 Committed: https://crrev.com/c11e2e0b957aa01a05fb53b2fc627d73b82da3c8 Cr-Commit-Position: refs/heads/master@{#338393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M sandbox/win/src/process_mitigations.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/src/service_resolver_32.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 5 months ago (2015-07-10 22:40:18 UTC) #2
Will Harris
lgtm... someone will inevitably complain these are gone... but we have history :)
5 years, 5 months ago (2015-07-10 22:43:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232723002/1
5 years, 5 months ago (2015-07-10 22:45:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 23:22:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 23:24:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c11e2e0b957aa01a05fb53b2fc627d73b82da3c8
Cr-Commit-Position: refs/heads/master@{#338393}

Powered by Google App Engine
This is Rietveld 408576698