Small fix to AddAppVerifierTestStep.

Small fix to AddAppVerifierTestStep.

A change to GetPythonTestCommand aggravated this latent bug.

BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=183641

[chrisha, 2013-02-20 18:14:33]

PTAL.

[Sigurður Ásgeirsson, 2013-02-20 21:20:22]

lgtm

[chrisha, 2013-02-20 21:22:03]

Thanks, committing.

[commit-bot: I haz the power, 2013-02-20 21:22:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/12327012/1

[commit-bot: I haz the power, 2013-02-20 21:26:02]

Presubmit check for 12327012-1 failed and returned exit status 1.

INFO:root:Found 1 file(s).
INFO:PRESUBMIT:Running pylint on: ['PRESUBMIT.py', 'test/masters_test.py',
'test/tryserver_mail_test.py', 'test/masters_cfg_test.py',
'test/masters_util.py', 'test/slaves_cfg_test.py', 'test/test_env.py',
'slave/run_slave.py', 'site_config/config_default.py', 'site_config/config.py',
'site_config/__init__.py', 'site_config/config_bootstrap.py',
'scripts/common/find_depot_tools.py', 'scripts/common/master_cfg_utils.py',
'scripts/common/archive_utils.py', 'scripts/common/archive_utils_unittest.py',
'scripts/common/chromium_utils.py', 'scripts/common/__init__.py',
'scripts/common/printable.py', 'scripts/common/gtest_utils.py',
'scripts/common/unittests/chromium_utils.py',
'scripts/common/unittests/gtest_utils_test.py',
'scripts/common/unittests/test_env.py', 'scripts/slave/zip_build.py',
'scripts/slave/gsutil_cp_dir.py', 'scripts/slave/gitzip.py',
'scripts/slave/reliability_tests.py', 'scripts/slave/process_log_utils.py',
'scripts/slave/get_swarm_results.py', 'scripts/slave/cleanup_temp.py',
'scripts/slave/get_build_for_chromebot.py', 'scripts/slave/runbuild.py',
'scripts/slave/__init__.py', 'scripts/slave/telemetry.py',
'scripts/slave/gsutil_download.py', 'scripts/slave/bootstrap.py',
'scripts/slave/builder_utils.py', 'scripts/slave/random_delay.py',
'scripts/slave/crash_utils.py', 'scripts/slave/runbuild_utils.py',
'scripts/slave/extract_build.py', 'scripts/slave/add_network_drive.py',
'scripts/slave/svn.py', 'scripts/slave/process_dumps.py',
'scripts/slave/gtest_slave_utils.py', 'scripts/slave/archive_profiling_data.py',
'scripts/slave/compile.py', 'scripts/slave/test_x_server.py',
'scripts/slave/manifest_to_hash.py', 'scripts/slave/cleanup_old_files.py',
'scripts/slave/kill_processes.py', 'scripts/slave/slave_utils.py',
'scripts/slave/runtest.py', 'scripts/slave/chromium_commands.py',
'scripts/slave/xvfb.py', 'scripts/slave/gtest/__init__.py',
'scripts/slave/gtest/networktransaction.py',
'scripts/slave/gtest/test_result.py',
'scripts/slave/gtest/json_results_generator.py',
'scripts/slave/gtest/test_results_uploader.py',
'scripts/slave/gtest/json_results_generator_unittest.py',
'scripts/slave/skia/upload_to_bucket.py',
'scripts/slave/skia/merge_into_svn.py',
'scripts/slave/unittests/get_swarm_results_test.py',
'scripts/slave/unittests/extract_build_test.py',
'scripts/slave/unittests/telemetry_test.py',
'scripts/slave/unittests/slave_utils_test_broken.py',
'scripts/slave/unittests/buildrunner_test.py',
'scripts/slave/unittests/runtest_annotator_test.py',
'scripts/slave/unittests/cleanup_old_files_test.py',
'scripts/slave/unittests/test_env.py', 'scripts/slave/syzygy/gsutil_cp_dir.py',
'scripts/slave/chromium/devtools_perf_test_wrapper.py',
'scripts/slave/chromium/dart_buildbot_run.py',
'scripts/slave/chromium/asan_archive_build.py',
'scripts/slave/chromium/archive_build_unittest.py',
'scripts/slave/chromium/run_crash_handler.py',
'scripts/slave/chromium/layout_test_wrapper.py',
'scripts/slave/chromium/__init__.py',
'scripts/slave/chromium/playback_benchmark_replay.py',
'scripts/slave/chromium/archive_gpu_pixel_test_results.py',
'scripts/slave/chromium/archive_build.py',
'scripts/slave/chromium/archive_file.py',
'scripts/slave/chromium/resource_sizes.py',
'scripts/slave/chromium/process_coverage.py',
'scripts/slave/chromium/dom_perf.py',
'scripts/slave/chromium/nacl_sdk_buildbot_run.py',
'scripts/slave/chromium/archive_crash_dumps.py',
'scripts/slave/chromium/lint_test_files_wrapper.py',
'scripts/slave/chromium/package_source.py', 'scripts/slave/chromium/sizes.py',
'scripts/slave/chromium/upload_parity_data.py',
'scripts/slave/chromium/archive_coverage.py',
'scripts/slave/chromium/archive_layout_test_results.py',
'scripts/slave/chromium/playback_benchmark.py',
'scripts/slave/chromium/win_apply_asan.py',
'scripts/slave/chromium/qa_buildbot_run.py',
'scripts/slave/chromium/check_lkgr.py', 'scripts/slave/dart/dart_util.py',
'scripts/slave/v8/v8archive.py', 'scripts/slave/v8/v8testing.py',
'scripts/slave/o3d/upload_build.py',
'scripts/slave/o3d/prepare_selenium_tests.py', 'scripts/slave/o3d/__init__.py',
'scripts/slave/o3d/unpack_test_archive.py',
'scripts/slave/android/flash_devices.py', 'scripts/master/gatekeeper.py',
'scripts/master/slaves_list.py', 'scripts/master/chromium_git_poller_bb8.py',
'scripts/master/url_poller.py', 'scripts/master/chromium_status_bb8.py',
'scripts/master/builders_pools.py', 'scripts/master/chromium_step.py',
'scripts/master/status_push.py', 'scripts/master/cros_try_job_git.py',
'scripts/master/chromium_notifier.py', 'scripts/master/master_utils.py',
'scripts/master/__init__.py', 'scripts/master/build_sheriffs.py',
'scripts/master/try_job_base.py', 'scripts/master/chromium_fail_notifier.py',
'scripts/master/goodrevisions.py', 'scripts/master/status_gerrit.py',
'scripts/master/master_config.py', 'scripts/master/cros_filter.py',
'scripts/master/build_utils.py', 'scripts/master/try_mail_notifier.py',
'scripts/master/try_job_http.py', 'scripts/master/failures_history.py',
'scripts/master/get_password.py', 'scripts/master/failures_notifier.py',
'scripts/master/try_job_svn.py', 'scripts/master/perf_notifier.py',
'scripts/master/repo_poller.py', 'scripts/master/perf_count_notifier.py',
'scripts/master/nacl_sdk_mono_changes.py', 'scripts/master/try_job_rietveld.py',
'scripts/master/optional_arguments.py',
'scripts/master/autoreboot_buildslave.py',
'scripts/master/integrationtests/try_job_rietveld_test.py',
'scripts/master/integrationtests/test_env.py',
'scripts/master/unittests/failures_notifier_test.py',
'scripts/master/unittests/gatekeeper_test.py',
'scripts/master/unittests/failures_history_test.py',
'scripts/master/unittests/test_repo_poller.py',
'scripts/master/unittests/chromium_utils_test.py',
'scripts/master/unittests/try_job_base_test.py',
'scripts/master/unittests/chromium_notifier_test.py',
'scripts/master/unittests/perf_count_notifier_test.py',
'scripts/master/unittests/gclient_source_test.py',
'scripts/master/unittests/lkgr_finder_unittest.py',
'scripts/master/unittests/process_log_test.py',
'scripts/master/unittests/test_env.py',
'scripts/master/unittests/chromium_commands_test.py',
'scripts/master/unittests/annotator_test.py',
'scripts/master/log_parser/retcode_command.py',
'scripts/master/log_parser/archive_command.py',
'scripts/master/log_parser/__init__.py',
'scripts/master/log_parser/webkit_test_command.py',
'scripts/master/log_parser/process_log.py',
'scripts/master/factory/swarm_commands.py',
'scripts/master/factory/nacl_sdk_factory.py',
'scripts/master/factory/build_factory.py',
'scripts/master/factory/dart_factory.py',
'scripts/master/factory/nacl_sdk_commands.py',
'scripts/master/factory/commands.py',
'scripts/master/factory/libyuv_factory.py',
'scripts/master/factory/nacl_commands.py',
'scripts/master/factory/nacl_factory.py',
'scripts/master/factory/dart_commands.py',
'scripts/master/factory/gclient_factory.py',
'scripts/master/factory/drmemory_factory.py', 'scripts/master/factory/build.py',
'scripts/master/factory/nacl_addin_factory.py',
'scripts/master/factory/gyp_factory.py',
'scripts/master/factory/chromeos_build.py',
'scripts/master/factory/__init__.py',
'scripts/master/factory/pagespeed_commands.py',
'scripts/master/factory/swarm_factory.py',
'scripts/master/factory/nacl_ports_commands.py',
'scripts/master/factory/chromeos_build_factory.py',
'scripts/master/factory/libjingle_factory.py',
'scripts/master/factory/omaha_commands.py',
'scripts/master/factory/omaha_factory.py',
'scripts/master/factory/v8_factory.py',
'scripts/master/factory/chromeos_factory.py',
'scripts/master/factory/nacl_ports_factory.py',
'scripts/master/factory/syzygy_commands.py',
'scripts/master/factory/webrtc_factory.py',
'scripts/master/factory/webm_factory.py',
'scripts/master/factory/pagespeed_factory.py',
'scripts/master/factory/syzygy_factory.py',
'scripts/master/factory/chromium_factory.py',
'scripts/master/factory/chromium_commands.py',
'scripts/master/factory/webm_commands.py',
'scripts/master/factory/v8_commands.py',
'scripts/master/factory/skia/commands.py',
'scripts/master/factory/skia/factory.py',
'scripts/master/factory/skia/__init__.py',
'scripts/master/factory/skia/android_factory.py',
'scripts/tools/hung_slaves.py', 'scripts/tools/cleanup_slaves.py',
'scripts/tools/make_manhole.py', 'scripts/tools/downgrade_buildsteps.py',
'scripts/tools/swarm_bot_setup.py', 'scripts/tools/botmap.py',
'scripts/tools/monitor_masters.py', 'scripts/tools/try_jobs.py',
'scripts/tools/state_create.py', 'scripts/tools/slaves.py',
'scripts/tools/swarm_bootstrap/dimensions_generator.py',
'scripts/tools/swarm_bootstrap/slave_machine.py',
'scripts/tools/swarm_bootstrap/swarm_constants.py',
'scripts/tools/swarm_bootstrap/url_helper.py',
'masters/master.client.v8/branches_cfg.py',
'masters/master.chromium.memory/master_mac_cfg.py',
'masters/master.chromium.memory/master_source_cfg.py',
'masters/master.chromium.memory/master_chromeos_cfg.py',
'masters/master.chromium.memory/master_gatekeeper_cfg.py',
'masters/master.chromium.memory/master_linux_cfg.py',
'masters/master.chromium.win/master_source_cfg.py',
'masters/master.chromium.win/master_site_config.py',
'masters/master.chromium.win/master_gatekeeper_cfg.py',
'masters/master.chromium.win/master_win_cfg.py',
'masters/master.client.skia/master_source_cfg.py',
'masters/master.client.skia/master_builders_cfg.py',
'masters/master.chromium/master_source_cfg.py',
'masters/master.chromium/master_gatekeeper_cfg.py',
'masters/master.chromium/master_full_cfg.py',
'masters/master.chromium.webrtc/master_mac_cfg.py',
'masters/master.chromium.webrtc/master_source_cfg.py',
'masters/master.chromium.webrtc/master_linux_cfg.py',
'masters/master.chromium.webrtc/master_win_cfg.py',
'masters/master.chromium.webrtc/master_cros_cfg.py',
'masters/master.chromium.webrtc.fyi/master_mac_cfg.py',
'masters/master.chromium.webrtc.fyi/master_source_cfg.py', 'masters/maste…
(message too large)

[chrisha, 2013-02-20 21:49:29]

(Siggi, you can ignore this.)

+Robert (an owner)

PTAL?

[iannucci, 2013-02-20 22:39:12]

On 2013/02/20 21:49:29, chrisha wrote:
> (Siggi, you can ignore this.)
> 
> +Robert (an owner)
> 
> PTAL?

This totally lgtm :)

[commit-bot: I haz the power, 2013-02-20 22:39:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisha@chromium.org/12327012/1

[commit-bot: I haz the power, 2013-02-20 22:43:41]

Change committed as 183641