Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: sky/sdk/example/fitness/lib/settings.dart

Issue 1232673003: Delete drawerController and make drawer handle back behavior natively (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix settings page of fitness app Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/example/fitness/lib/main.dart ('k') | sky/sdk/example/stocks/lib/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/example/fitness/lib/settings.dart
diff --git a/sky/sdk/example/fitness/lib/settings.dart b/sky/sdk/example/fitness/lib/settings.dart
index d419b8ce8b4cc5425e2106b2afe1e3dd3f243f5c..51ac6f7532d3ac1028875a812213013f7f832848 100644
--- a/sky/sdk/example/fitness/lib/settings.dart
+++ b/sky/sdk/example/fitness/lib/settings.dart
@@ -9,6 +9,7 @@ import 'package:sky/widgets/icon_button.dart';
import 'package:sky/widgets/material.dart';
import 'package:sky/widgets/navigator.dart';
import 'package:sky/widgets/scaffold.dart';
+import 'package:sky/widgets/scrollable_viewport.dart';
import 'package:sky/widgets/tool_bar.dart';
import 'package:sky/widgets/theme.dart';
@@ -45,25 +46,27 @@ class SettingsFragment extends Component {
Widget buildSettingsPane() {
return new Material(
type: MaterialType.canvas,
- child: new Container(
- padding: const EdgeDims.symmetric(vertical: 20.0),
- child: new Block([
- new DrawerItem(
- onPressed: () { _handleBackupChanged(!(backup == BackupMode.enabled)); },
- children: [
- new Flexible(child: new Text('Back up data to the cloud')),
- new Switch(value: backup == BackupMode.enabled, onChanged: _handleBackupChanged)
- ]
- ),
- new DrawerItem(
- children: [
- new Block([
- new Text('Height'),
- new Text("6'2\"", style: Theme.of(this).text.caption),
- ])
- ]
- ),
- ])
+ child: new ScrollableViewport(
+ child: new Container(
+ padding: const EdgeDims.symmetric(vertical: 20.0),
+ child: new Block([
+ new DrawerItem(
+ onPressed: () { _handleBackupChanged(!(backup == BackupMode.enabled)); },
+ children: [
+ new Flexible(child: new Text('Back up data to the cloud')),
+ new Switch(value: backup == BackupMode.enabled, onChanged: _handleBackupChanged)
+ ]
+ ),
+ new DrawerItem(
+ children: [
+ new Flex([
+ new Text('Height'),
+ new Text("6'2\"", style: Theme.of(this).text.caption),
+ ], direction: FlexDirection.vertical, alignItems: FlexAlignItems.start)
+ ]
+ ),
+ ])
+ )
)
);
}
« no previous file with comments | « sky/sdk/example/fitness/lib/main.dart ('k') | sky/sdk/example/stocks/lib/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698