src/arm/lithium-codegen-arm.cc - Issue 123263005: Fix some out-of-line constant pool garbage collection bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 123263005: Fix some out-of-line constant pool garbage collection bugs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix other arches Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 6bbdcc90d759ef11076b733237e0ba7af5801374..622cbf8d6affe40a786d37c5014994684e373a8a 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -979,6 +979,10 @@ void LCodeGen::RecordSafepoint(

safepoint.DefinePointerRegister(ToRegister(pointer), zone());

}

+ if (FLAG_enable_ool_constant_pool && (kind & Safepoint::kWithRegisters)) {

+ // Register pp always contains a pointer to the context.

ulan 2014/01/07 08:32:03 Register pp always contains a pointer to the const

rmcilroy 2014/01/07 14:57:29 Good catch :). Done.

+ safepoint.DefinePointerRegister(pp, zone());

+ }

}

« no previous file with comments | « src/arm/frames-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »