Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: src/objects.cc

Issue 123263005: Fix some out-of-line constant pool garbage collection bugs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9442 matching lines...) Expand 10 before | Expand all | Expand 10 after
9453 int properties = mode == CLEAR_INOBJECT_PROPERTIES 9453 int properties = mode == CLEAR_INOBJECT_PROPERTIES
9454 ? 0 : other->inobject_properties(); 9454 ? 0 : other->inobject_properties();
9455 return CheckEquivalent(this, other) && inobject_properties() == properties; 9455 return CheckEquivalent(this, other) && inobject_properties() == properties;
9456 } 9456 }
9457 9457
9458 9458
9459 void ConstantPoolArray::ConstantPoolIterateBody(ObjectVisitor* v) { 9459 void ConstantPoolArray::ConstantPoolIterateBody(ObjectVisitor* v) {
9460 if (count_of_ptr_entries() > 0) { 9460 if (count_of_ptr_entries() > 0) {
9461 int first_ptr_offset = OffsetOfElementAt(first_ptr_index()); 9461 int first_ptr_offset = OffsetOfElementAt(first_ptr_index());
9462 int last_ptr_offset = 9462 int last_ptr_offset =
9463 OffsetOfElementAt(first_ptr_index() + count_of_ptr_entries()); 9463 OffsetOfElementAt(first_ptr_index() + count_of_ptr_entries() - 1);
9464 v->VisitPointers( 9464 v->VisitPointers(
9465 HeapObject::RawField(this, first_ptr_offset), 9465 HeapObject::RawField(this, first_ptr_offset),
9466 HeapObject::RawField(this, last_ptr_offset)); 9466 HeapObject::RawField(this, last_ptr_offset));
9467 } 9467 }
9468 } 9468 }
9469 9469
9470 9470
9471 void JSFunction::JSFunctionIterateBody(int object_size, ObjectVisitor* v) { 9471 void JSFunction::JSFunctionIterateBody(int object_size, ObjectVisitor* v) {
9472 // Iterate over all fields in the body but take care in dealing with 9472 // Iterate over all fields in the body but take care in dealing with
9473 // the code entry. 9473 // the code entry.
(...skipping 7168 matching lines...) Expand 10 before | Expand all | Expand 10 after
16642 #define ERROR_MESSAGES_TEXTS(C, T) T, 16642 #define ERROR_MESSAGES_TEXTS(C, T) T,
16643 static const char* error_messages_[] = { 16643 static const char* error_messages_[] = {
16644 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16644 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16645 }; 16645 };
16646 #undef ERROR_MESSAGES_TEXTS 16646 #undef ERROR_MESSAGES_TEXTS
16647 return error_messages_[reason]; 16647 return error_messages_[reason];
16648 } 16648 }
16649 16649
16650 16650
16651 } } // namespace v8::internal 16651 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/objects-visiting-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698