Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 123263005: Fix some out-of-line constant pool garbage collection bugs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/frames-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 961 matching lines...) Expand 10 before | Expand all | Expand 10 after
972 Safepoint safepoint = safepoints_.DefineSafepoint(masm(), 972 Safepoint safepoint = safepoints_.DefineSafepoint(masm(),
973 kind, arguments, deopt_mode); 973 kind, arguments, deopt_mode);
974 for (int i = 0; i < operands->length(); i++) { 974 for (int i = 0; i < operands->length(); i++) {
975 LOperand* pointer = operands->at(i); 975 LOperand* pointer = operands->at(i);
976 if (pointer->IsStackSlot()) { 976 if (pointer->IsStackSlot()) {
977 safepoint.DefinePointerSlot(pointer->index(), zone()); 977 safepoint.DefinePointerSlot(pointer->index(), zone());
978 } else if (pointer->IsRegister() && (kind & Safepoint::kWithRegisters)) { 978 } else if (pointer->IsRegister() && (kind & Safepoint::kWithRegisters)) {
979 safepoint.DefinePointerRegister(ToRegister(pointer), zone()); 979 safepoint.DefinePointerRegister(ToRegister(pointer), zone());
980 } 980 }
981 } 981 }
982 if (FLAG_enable_ool_constant_pool && (kind & Safepoint::kWithRegisters)) {
983 // Register pp always contains a pointer to the constant pool.
984 safepoint.DefinePointerRegister(pp, zone());
985 }
982 } 986 }
983 987
984 988
985 void LCodeGen::RecordSafepoint(LPointerMap* pointers, 989 void LCodeGen::RecordSafepoint(LPointerMap* pointers,
986 Safepoint::DeoptMode deopt_mode) { 990 Safepoint::DeoptMode deopt_mode) {
987 RecordSafepoint(pointers, Safepoint::kSimple, 0, deopt_mode); 991 RecordSafepoint(pointers, Safepoint::kSimple, 0, deopt_mode);
988 } 992 }
989 993
990 994
991 void LCodeGen::RecordSafepoint(Safepoint::DeoptMode deopt_mode) { 995 void LCodeGen::RecordSafepoint(Safepoint::DeoptMode deopt_mode) {
(...skipping 4816 matching lines...) Expand 10 before | Expand all | Expand 10 after
5808 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5812 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5809 __ ldr(result, FieldMemOperand(scratch, 5813 __ ldr(result, FieldMemOperand(scratch,
5810 FixedArray::kHeaderSize - kPointerSize)); 5814 FixedArray::kHeaderSize - kPointerSize));
5811 __ bind(&done); 5815 __ bind(&done);
5812 } 5816 }
5813 5817
5814 5818
5815 #undef __ 5819 #undef __
5816 5820
5817 } } // namespace v8::internal 5821 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/frames-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698