Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Side by Side Diff: src/arm/frames-arm.h

Issue 123263005: Fix some out-of-line constant pool garbage collection bugs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/frames-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 class EntryFrameConstants : public AllStatic { 103 class EntryFrameConstants : public AllStatic {
104 public: 104 public:
105 static const int kCallerFPOffset = 105 static const int kCallerFPOffset =
106 -(StandardFrameConstants::kFixedFrameSizeFromFp + kPointerSize); 106 -(StandardFrameConstants::kFixedFrameSizeFromFp + kPointerSize);
107 }; 107 };
108 108
109 109
110 class ExitFrameConstants : public AllStatic { 110 class ExitFrameConstants : public AllStatic {
111 public: 111 public:
112 static const int kCodeOffset = -2 * kPointerSize; 112 static const int kFrameSize = FLAG_enable_ool_constant_pool ?
113 static const int kSPOffset = -1 * kPointerSize; 113 3 * kPointerSize : 2 * kPointerSize;
114
115 static const int kConstantPoolOffset = FLAG_enable_ool_constant_pool ?
116 -3 * kPointerSize : 0;
117 static const int kCodeOffset = -2 * kPointerSize;
118 static const int kSPOffset = -1 * kPointerSize;
114 119
115 // The caller fields are below the frame pointer on the stack. 120 // The caller fields are below the frame pointer on the stack.
116 static const int kCallerFPOffset = 0 * kPointerSize; 121 static const int kCallerFPOffset = 0 * kPointerSize;
117 // The calling JS function is below FP. 122 // The calling JS function is below FP.
118 static const int kCallerPCOffset = 1 * kPointerSize; 123 static const int kCallerPCOffset = 1 * kPointerSize;
119 124
120 // FP-relative displacement of the caller's SP. It points just 125 // FP-relative displacement of the caller's SP. It points just
121 // below the saved PC. 126 // below the saved PC.
122 static const int kCallerSPDisplacement = 2 * kPointerSize; 127 static const int kCallerSPDisplacement = 2 * kPointerSize;
123 }; 128 };
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 178
174 179
175 inline void StackHandler::SetFp(Address slot, Address fp) { 180 inline void StackHandler::SetFp(Address slot, Address fp) {
176 Memory::Address_at(slot) = fp; 181 Memory::Address_at(slot) = fp;
177 } 182 }
178 183
179 184
180 } } // namespace v8::internal 185 } } // namespace v8::internal
181 186
182 #endif // V8_ARM_FRAMES_ARM_H_ 187 #endif // V8_ARM_FRAMES_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | src/arm/frames-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698