Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/browser/ui/sync/one_click_signin_bubble_links_delegate.cc

Issue 123263004: Fix the advanced link on signin bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/sync/one_click_signin_bubble_links_delegate.h" 5 #include "chrome/browser/ui/sync/one_click_signin_bubble_links_delegate.h"
6 6
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/browser_navigator.h" 8 #include "chrome/browser/ui/browser_navigator.h"
9 #include "chrome/browser/ui/chrome_pages.h"
9 #include "chrome/common/url_constants.h" 10 #include "chrome/common/url_constants.h"
10 11
11 OneClickSigninBubbleLinksDelegate::OneClickSigninBubbleLinksDelegate( 12 OneClickSigninBubbleLinksDelegate::OneClickSigninBubbleLinksDelegate(
12 Browser* browser) : browser_(browser) {} 13 Browser* browser) : browser_(browser) {}
13 14
14 OneClickSigninBubbleLinksDelegate::~OneClickSigninBubbleLinksDelegate() {} 15 OneClickSigninBubbleLinksDelegate::~OneClickSigninBubbleLinksDelegate() {}
15 16
16 void OneClickSigninBubbleLinksDelegate::OnLearnMoreLinkClicked( 17 void OneClickSigninBubbleLinksDelegate::OnLearnMoreLinkClicked(
17 bool is_dialog) { 18 bool is_dialog) {
18 chrome::NavigateParams params(browser_, 19 chrome::NavigateParams params(browser_,
19 GURL(chrome::kChromeSyncLearnMoreURL), 20 GURL(chrome::kChromeSyncLearnMoreURL),
20 content::PAGE_TRANSITION_LINK); 21 content::PAGE_TRANSITION_LINK);
21 params.disposition = is_dialog ? NEW_WINDOW : NEW_FOREGROUND_TAB; 22 params.disposition = is_dialog ? NEW_WINDOW : NEW_FOREGROUND_TAB;
22 chrome::Navigate(&params); 23 chrome::Navigate(&params);
23 } 24 }
24 25
25 void OneClickSigninBubbleLinksDelegate::OnAdvancedLinkClicked() { 26 void OneClickSigninBubbleLinksDelegate::OnAdvancedLinkClicked() {
26 chrome::NavigateParams params(browser_, 27 chrome::ShowSettingsSubPage(browser_, chrome::kSyncSetupSubPage);
27 GURL(chrome::kChromeUISettingsURL),
28 content::PAGE_TRANSITION_LINK);
29 params.disposition = CURRENT_TAB;
30 chrome::Navigate(&params);
31 } 28 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698