Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1232613002: [turbofan] Fix undefined behavior in InstructionSequence::GetInstructionBlock. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix undefined behavior in InstructionSequence::GetInstructionBlock. Some implementations of std::lower_bound require weak-strict ordering. The comparison operator must be assymetric, which doesn't hold for less_equals. Committed: https://crrev.com/47bcd1a139451204667949ee4836724b64fb2996 Cr-Commit-Position: refs/heads/master@{#29633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/compiler/instruction.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 5 months ago (2015-07-13 10:52:18 UTC) #2
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-14 02:50:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232613002/1
5 years, 5 months ago (2015-07-14 02:50:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 03:33:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 03:33:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47bcd1a139451204667949ee4836724b64fb2996
Cr-Commit-Position: refs/heads/master@{#29633}

Powered by Google App Engine
This is Rietveld 408576698