Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 12326129: Pass in a consistent build-dir value. (Closed)

Created:
7 years, 10 months ago by iannucci
Modified:
7 years, 9 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Pass in a consistent build-dir value. This is not the CORRECT value, but currently the android scripts are the only ones which rely on zip_build providing a default for this value, so pass a wrong-but-consistent value. Correct value coming soon. TBR=ilevy@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184886

Patch Set 1 #

Patch Set 2 : Use out instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/buildbot/buildbot_functions.sh View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
iannucci
PTAL
7 years, 10 months ago (2013-02-26 19:26:30 UTC) #1
iannucci
On 2013/02/26 19:26:30, iannucci wrote: > PTAL TBR'ing since it worked on the trybots.
7 years, 10 months ago (2013-02-26 22:03:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/12326129/1
7 years, 10 months ago (2013-02-26 22:03:41 UTC) #3
Isaac (away)
lgtm. I've had issues in the past with the builddir in extract build (fixed in ...
7 years, 10 months ago (2013-02-26 22:13:58 UTC) #4
iannucci
On 2013/02/26 22:13:58, Isaac wrote: > lgtm. I've had issues in the past with the ...
7 years, 10 months ago (2013-02-26 22:21:24 UTC) #5
Isaac (away)
chromium.webkit, as in chromium buildbots w/ tip of tree webkit.. .
7 years, 10 months ago (2013-02-26 22:50:15 UTC) #6
iannucci
On 2013/02/26 22:50:15, Isaac wrote: > chromium.webkit, as in chromium buildbots w/ tip of tree ...
7 years, 10 months ago (2013-02-26 22:56:05 UTC) #7
iannucci
7 years, 9 months ago (2013-02-27 05:42:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r184886 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698