chrome/tools/build/win/create_installer_archive.py - Issue 12326117: Fix create_installer_archive.py to be more flexible with output directory names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/build/win/create_installer_archive.py

Issue 12326117: Fix create_installer_archive.py to be more flexible with output directory names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix boolean booboo Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/tools/build/win/create_installer_archive.py

diff --git a/chrome/tools/build/win/create_installer_archive.py b/chrome/tools/build/win/create_installer_archive.py

index 909ae96794a5b13fea63ae806a1ff396765ee72d..9347b7c3d4b323b11383cd5b90750f64bad2de1e 100755

--- a/chrome/tools/build/win/create_installer_archive.py

+++ b/chrome/tools/build/win/create_installer_archive.py

@@ -353,8 +353,8 @@ def CopyAndAugmentManifest(build_dir, output_dir, manifest_name,

# of VS installed to make sure we have the correct CRT version, unused DLLs

# should not conflict with the others anyways.

def CopyVisualStudioRuntimeDLLs(build_dir):

- is_debug = os.path.basename(build_dir) == 'Debug'

- if not is_debug and os.path.basename(build_dir) != 'Release':

+ is_debug = os.path.basename(build_dir).startswith('Debug')

+ if not is_debug and not os.path.basename(build_dir).startswith('Release'):

print ("Warning: could not determine build configuration from "

"output directory, assuming Release build.")

« no previous file with comments | « no previous file | no next file » | no next file with comments »