Made notification center notifications collapsed and expandable.

ui/message_center/message_center_bubble.h

Index: ui/message_center/message_center_bubble.h
diff --git a/ui/message_center/message_center_bubble.h b/ui/message_center/message_center_bubble.h
index ba7adfad4493d3c9566f008e7a123a409431b3d2..6ceaf8a655e83a10ae71e19974a189a0b17afeb1 100644
--- a/ui/message_center/message_center_bubble.h
+++ b/ui/message_center/message_center_bubble.h
@@ -11,16 +11,18 @@
 
 namespace message_center {
 
-class MessageCenterContentsView;
+class MessageCenterView;
 
 // Bubble for message center.
-class MESSAGE_CENTER_EXPORT MessageCenterBubble : public MessageBubbleBase {
+class MESSAGE_CENTER_EXPORT MessageCenterBubble
+    : public MessageBubbleBase,
+      public NotificationList::Delegate {

[dharcourt, 2013/03/01 10:17:31]

MessageCenterBubble now implements NotificationList::Delegate so it can
intercept its OnExpand() method and perform appropriate view updates on
notification expansion.

[Jun Mukai, 2013/03/01 21:44:42]

Inheriting Delegate is not a good idea here. Usually a delegate has 1-1
relationship with the target instance (NotificationList here).
Also this class seems delegating the message center instead of the notification
list.

I think you should declare your own methods with another name. I don't have a
good name in my mind (sorry!), but this should not be a
NotificationList::Delegate.  Probably MessageView::Delegate or
Notification::Delegate?  not sure.

[dharcourt, 2013/03/02 02:08:02]

Sounds good. I've implemented this by taking the
delegate-of-things-that-change-notifications functionality out of
NotificationList::Delegate and into a new NotificationChangeDelegate. This
leaves NotificationList::Delegate much smaller, and used only by MessageCenter,
NotificationList's only delegate. NotificationChangeDelegate replaces
NotificationList::Delegate in MessageCenterBubble, MessagePopupBubble, and
MessageView. I think this is much cleaner than having a single delegate class
handling notification change delegation and notification list delegation.

  public:
-  explicit MessageCenterBubble(NotificationList::Delegate* delegate);
+  explicit MessageCenterBubble(MessageCenter* message_center);
 
   virtual ~MessageCenterBubble();
 
-  // Overridden from MessageBubbleBase.
+  // Overridden from MessageBubbleBase:
   virtual views::TrayBubbleView::InitParams GetInitParams(
       views::TrayBubbleView::AnchorAlignment anchor_alignment) OVERRIDE;
   virtual void InitializeContents(views::TrayBubbleView* bubble_view) OVERRIDE;
@@ -29,10 +31,24 @@ class MESSAGE_CENTER_EXPORT MessageCenterBubble : public MessageBubbleBase {
   virtual void OnMouseEnteredView() OVERRIDE;
   virtual void OnMouseExitedView() OVERRIDE;
 
+  // Overridden from NotificationList::Delegate:
+  virtual void SendRemoveNotification(const std::string& id,
+                                      bool by_user) OVERRIDE;
+  virtual void SendRemoveAllNotifications(bool by_user) OVERRIDE;
+  virtual void DisableNotificationByExtension(const std::string& id) OVERRIDE;
+  virtual void DisableNotificationByUrl(const std::string& id) OVERRIDE;
+  virtual void ShowNotificationSettings(const std::string& id) OVERRIDE;
+  virtual void ShowNotificationSettingsDialog(gfx::NativeView context) OVERRIDE;
+  virtual void OnNotificationClicked(const std::string& id) OVERRIDE;
+  virtual void OnButtonClicked(const std::string& id,
+                               int button_index) OVERRIDE;
+  virtual void OnExpand(const std::string& id) OVERRIDE;
+  virtual void OnQuietModeChanged(bool quiet_mode) OVERRIDE;
+
   size_t NumMessageViewsForTest() const;
 
  private:
-  MessageCenterContentsView* contents_view_;
+  MessageCenterView* contents_view_;
 
   // The maximum height
   int max_height_;