chrome/browser/notifications/message_center_notification_manager.cc - Issue 12326091: Made notification center notifications collapsed and expandable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 12326091: Made notification center notifications collapsed and expandable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased, which led to many changes. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index bed05540b7791dfdce47be8430f60a49035a50ea..27eafa4367fec5c8937aefa741e79d319ffe1d38 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -141,7 +141,7 @@ bool MessageCenterNotificationManager::UpdateNotification(

old_notification->profile()->IsSameProfile(profile)) {

std::string old_id =

old_notification->notification().notification_id();

- DCHECK(message_center_->GetNotificationList()->HasNotification(old_id));

+ DCHECK(message_center_->notification_list()->HasNotification(old_id));

dharcourt 2013/03/01 10:17:31 GetNotificationList() was a functional duplicate o

// Add/remove notification in the local list but just update the same

// one in MessageCenter.

« no previous file with comments | « no previous file | ui/message_center/message_bubble_base.h » ('j') | ui/message_center/message_bubble_base.h » ('J')