Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1823)

Unified Diff: ui/message_center/message_view.h

Issue 12326091: Made notification center notifications collapsed and expandable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/message_view.h
diff --git a/ui/message_center/message_view.h b/ui/message_center/message_view.h
index be36eb4edc6bd6ff7d9dc89c164602dbd2f4c1f0..4dcc44069ffb00cc7faca4b083149d60b5bbca65 100644
--- a/ui/message_center/message_view.h
+++ b/ui/message_center/message_view.h
@@ -9,10 +9,10 @@
#include "ui/message_center/notification_list.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/controls/slide_out_view.h"
-#include "ui/views/view.h"
namespace views {
class ImageButton;
+class ImageView;
class ScrollView;
}
@@ -34,10 +34,6 @@ class MessageView : public views::SlideOutView,
virtual ~MessageView();
- // Creates the elements that make up the view layout. Must be called
- // immediately after construction.
- virtual void SetUpView() = 0;
-
void set_scroller(views::ScrollView* scroller) { scroller_ = scroller; }
// Overridden from views::View.
@@ -50,6 +46,9 @@ class MessageView : public views::SlideOutView,
virtual void ButtonPressed(views::Button* sender,
const ui::Event& event) OVERRIDE;
+ virtual bool IsExpanded();
+ virtual void SetExpanded(bool expanded);
dharcourt 2013/02/23 04:32:00 These are not is_expanded() and set_expanded() bec
Jun Mukai 2013/02/26 02:23:30 nit: I am not so sure, but probably our style of d
dharcourt 2013/02/26 03:23:30 SGTM. Done.
+
protected:
MessageView();
@@ -62,15 +61,19 @@ class MessageView : public views::SlideOutView,
NotificationList::Delegate* list_delegate() { return list_delegate_; }
Notification& notification() { return notification_; }
views::ImageButton* close_button() { return close_button_.get(); }
+ views::ImageButton* expand_button() { return expand_button_.get(); }
views::ScrollView* scroller() { return scroller_; }
private:
NotificationList::Delegate* list_delegate_;
Notification notification_;
- scoped_ptr<views::ImageButton> close_button_;
+ scoped_ptr<views::ImageButton> close_button_;
+ scoped_ptr<views::ImageButton> expand_button_;
views::ScrollView* scroller_;
+ bool expanded_;
+
DISALLOW_COPY_AND_ASSIGN(MessageView);
};

Powered by Google App Engine
This is Rietveld 408576698