components/guest_view/browser/test_guest_view_manager.h - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/test_guest_view_manager.h

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Now using weak pointer to GuestViewManager. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/guest_view/browser/guest_view_manager.cc ('K') | « components/guest_view/browser/guest_view_manager.cc ('k') | components/guest_view/browser/test_guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/test_guest_view_manager.h

diff --git a/components/guest_view/browser/test_guest_view_manager.h b/components/guest_view/browser/test_guest_view_manager.h

index 76f0cd7e98d1eaef182c1ea79432221dabba8239..f3ffe9879e7dacd71d65f07afadd910a73a55f08 100644

--- a/components/guest_view/browser/test_guest_view_manager.h

+++ b/components/guest_view/browser/test_guest_view_manager.h

@@ -74,7 +74,7 @@ class TestGuestViewManager : public GuestViewManager {

void AddGuest(int guest_instance_id,

content::WebContents* guest_web_contents) override;

void RemoveGuest(int guest_instance_id) override;

- void EmbedderWillBeDestroyed(int embedder_process_id) override;

+ void EmbedderProcessDestroyed(int embedder_process_id) override;

void ViewGarbageCollected(int embedder_process_id,

int view_instance_id) override;