components/guest_view/browser/guest_view_base.h - Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Now using weak pointer to GuestViewManager. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/guest_view/browser/guest_view_base.h

diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h

index 6a529806416ea86a7c3ed73c4e8c58f830dd8baf..2e7862d71dcfa4062f766b44dcc390e4d6526adc 100644

--- a/components/guest_view/browser/guest_view_base.h

+++ b/components/guest_view/browser/guest_view_base.h

@@ -65,7 +65,9 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

// potentially be created and destroyed in JavaScript before getting a

// GuestViewBase instance. This method can be hidden by a CleanUp() method in

// a derived class, in which case the derived method should call this one.

- static void CleanUp(int embedder_process_id, int view_instance_id);

+ static void CleanUp(content::BrowserContext* browser_context,

+ int embedder_process_id,

+ int view_instance_id);

static GuestViewBase* FromWebContents(

const content::WebContents* web_contents);

« no previous file with comments | « no previous file | components/guest_view/browser/guest_view_base.cc » ('j') | components/guest_view/browser/guest_view_manager.cc » ('J')