Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: components/guest_view/browser/test_guest_view_manager.h

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment by kalman@. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_ 5 #ifndef COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_
6 #define COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_ 6 #define COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_
7 7
8 #include "base/memory/linked_ptr.h" 8 #include "base/memory/linked_ptr.h"
9 #include "components/guest_view/browser/guest_view_manager.h" 9 #include "components/guest_view/browser/guest_view_manager.h"
10 #include "components/guest_view/browser/guest_view_manager_factory.h" 10 #include "components/guest_view/browser/guest_view_manager_factory.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // Returns the last guest instance ID removed from the manager. 67 // Returns the last guest instance ID removed from the manager.
68 int last_instance_id_removed() const { return last_instance_id_removed_; } 68 int last_instance_id_removed() const { return last_instance_id_removed_; }
69 69
70 private: 70 private:
71 FRIEND_TEST_ALL_PREFIXES(GuestViewManagerTest, AddRemove); 71 FRIEND_TEST_ALL_PREFIXES(GuestViewManagerTest, AddRemove);
72 72
73 // GuestViewManager override: 73 // GuestViewManager override:
74 void AddGuest(int guest_instance_id, 74 void AddGuest(int guest_instance_id,
75 content::WebContents* guest_web_contents) override; 75 content::WebContents* guest_web_contents) override;
76 void RemoveGuest(int guest_instance_id) override; 76 void RemoveGuest(int guest_instance_id) override;
77 void EmbedderWillBeDestroyed(int embedder_process_id) override; 77 void EmbedderProcessDestroyed(int embedder_process_id) override;
78 void ViewGarbageCollected(int embedder_process_id, 78 void ViewGarbageCollected(int embedder_process_id,
79 int view_instance_id) override; 79 int view_instance_id) override;
80 80
81 void WaitForGuestCreated(); 81 void WaitForGuestCreated();
82 82
83 void WaitForViewGarbageCollected(); 83 void WaitForViewGarbageCollected();
84 84
85 using GuestViewManager::last_instance_id_removed_; 85 using GuestViewManager::last_instance_id_removed_;
86 using GuestViewManager::removed_instance_ids_; 86 using GuestViewManager::removed_instance_ids_;
87 87
(...skipping 21 matching lines...) Expand all
109 109
110 private: 110 private:
111 TestGuestViewManager* test_guest_view_manager_; 111 TestGuestViewManager* test_guest_view_manager_;
112 112
113 DISALLOW_COPY_AND_ASSIGN(TestGuestViewManagerFactory); 113 DISALLOW_COPY_AND_ASSIGN(TestGuestViewManagerFactory);
114 }; 114 };
115 115
116 } // namespace guest_view 116 } // namespace guest_view
117 117
118 #endif // COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_ 118 #endif // COMPONENTS_GUEST_VIEW_BROWSER_TEST_GUEST_VIEW_MANAGER_H_
OLDNEW
« no previous file with comments | « components/guest_view/browser/guest_view_manager.cc ('k') | components/guest_view/browser/test_guest_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698