Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: components/guest_view/browser/test_guest_view_manager.cc

Issue 1232603002: This patch improves the way that GuestViewManager tracks the destruction of GuestView embedders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment by kalman@. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/guest_view/browser/test_guest_view_manager.h" 5 #include "components/guest_view/browser/test_guest_view_manager.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "components/guest_view/browser/guest_view_manager_delegate.h" 8 #include "components/guest_view/browser/guest_view_manager_delegate.h"
9 9
10 namespace guest_view { 10 namespace guest_view {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 ++num_guests_created_; 88 ++num_guests_created_;
89 89
90 if (created_message_loop_runner_.get()) 90 if (created_message_loop_runner_.get())
91 created_message_loop_runner_->Quit(); 91 created_message_loop_runner_->Quit();
92 } 92 }
93 93
94 void TestGuestViewManager::RemoveGuest(int guest_instance_id) { 94 void TestGuestViewManager::RemoveGuest(int guest_instance_id) {
95 GuestViewManager::RemoveGuest(guest_instance_id); 95 GuestViewManager::RemoveGuest(guest_instance_id);
96 } 96 }
97 97
98 void TestGuestViewManager::EmbedderWillBeDestroyed(int embedder_process_id) { 98 void TestGuestViewManager::EmbedderProcessDestroyed(int embedder_process_id) {
99 ++num_embedder_processes_destroyed_; 99 ++num_embedder_processes_destroyed_;
100 GuestViewManager::EmbedderWillBeDestroyed(embedder_process_id); 100 GuestViewManager::EmbedderProcessDestroyed(embedder_process_id);
101 } 101 }
102 102
103 void TestGuestViewManager::ViewGarbageCollected(int embedder_process_id, 103 void TestGuestViewManager::ViewGarbageCollected(int embedder_process_id,
104 int view_instance_id) { 104 int view_instance_id) {
105 GuestViewManager::ViewGarbageCollected(embedder_process_id, view_instance_id); 105 GuestViewManager::ViewGarbageCollected(embedder_process_id, view_instance_id);
106 ++num_views_garbage_collected_; 106 ++num_views_garbage_collected_;
107 if (gc_message_loop_runner_.get()) 107 if (gc_message_loop_runner_.get())
108 gc_message_loop_runner_->Quit(); 108 gc_message_loop_runner_->Quit();
109 } 109 }
110 110
111 // Test factory for creating test instances of GuestViewManager. 111 // Test factory for creating test instances of GuestViewManager.
112 TestGuestViewManagerFactory::TestGuestViewManagerFactory() 112 TestGuestViewManagerFactory::TestGuestViewManagerFactory()
113 : test_guest_view_manager_(NULL) { 113 : test_guest_view_manager_(NULL) {
114 } 114 }
115 115
116 TestGuestViewManagerFactory::~TestGuestViewManagerFactory() { 116 TestGuestViewManagerFactory::~TestGuestViewManagerFactory() {
117 } 117 }
118 118
119 GuestViewManager* TestGuestViewManagerFactory::CreateGuestViewManager( 119 GuestViewManager* TestGuestViewManagerFactory::CreateGuestViewManager(
120 content::BrowserContext* context, 120 content::BrowserContext* context,
121 scoped_ptr<GuestViewManagerDelegate> delegate) { 121 scoped_ptr<GuestViewManagerDelegate> delegate) {
122 if (!test_guest_view_manager_) { 122 if (!test_guest_view_manager_) {
123 test_guest_view_manager_ = 123 test_guest_view_manager_ =
124 new TestGuestViewManager(context, delegate.Pass()); 124 new TestGuestViewManager(context, delegate.Pass());
125 } 125 }
126 return test_guest_view_manager_; 126 return test_guest_view_manager_;
127 } 127 }
128 128
129 } // namespace guest_view 129 } // namespace guest_view
OLDNEW
« no previous file with comments | « components/guest_view/browser/test_guest_view_manager.h ('k') | extensions/browser/api/declarative/rules_registry_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698