Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1232583002: Update V8 DEPS. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update V8 DEPS. Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c Original CL: https://codereview.chromium.org/1232043002/ BUG= Committed: https://crrev.com/6211e1660492f653d30ddd1336bce6f9083ede94 Cr-Commit-Position: refs/heads/master@{#29598}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Add port https://codereview.chromium.org/1231093002/ #

Patch Set 4 : Newer clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -39 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232583002/20001
5 years, 5 months ago (2015-07-10 10:02:33 UTC) #3
Michael Achenbach
PTAL. Rolling clang including some fix attempts for new clang warnings, see: https://codereview.chromium.org/1232043002/
5 years, 5 months ago (2015-07-10 10:03:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 10:04:20 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/2582)
5 years, 5 months ago (2015-07-10 10:12:38 UTC) #7
Michael Achenbach
@Mips folks: Please add ports for this. The new clang version treats shift left of ...
5 years, 5 months ago (2015-07-10 12:23:02 UTC) #8
akos.palfi.imgtec
I've uploaded the MIPS port: https://codereview.chromium.org/1231093002
5 years, 5 months ago (2015-07-10 16:19:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232583002/40001
5 years, 5 months ago (2015-07-13 10:32:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-13 10:58:58 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6211e1660492f653d30ddd1336bce6f9083ede94 Cr-Commit-Position: refs/heads/master@{#29598}
5 years, 5 months ago (2015-07-13 10:59:15 UTC) #15
Michael Achenbach
5 years, 5 months ago (2015-07-13 11:45:00 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1232803003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Looks like another clang option got
deprecated:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-....

Powered by Google App Engine
This is Rietveld 408576698