Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1232573005: cc: Make sure we don't insert or remove layers during painting (Closed)

Created:
5 years, 5 months ago by ajuma
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make sure we don't insert or remove layers during painting Calling Layer::Update should not cause changes to tree topology. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/2b92d0faeb76efa29112da48ed7a193827d62017 Cr-Commit-Position: refs/heads/master@{#338385}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-use in_paint_layer_contents_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/trees/layer_tree_host.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
enne (OOO)
https://codereview.chromium.org/1232573005/diff/1/cc/layers/layer.cc File cc/layers/layer.cc (right): https://codereview.chromium.org/1232573005/diff/1/cc/layers/layer.cc#newcode138 cc/layers/layer.cc:138: DCHECK(!host->in_update()); Reuse host->in_paint_layer_contents()?
5 years, 5 months ago (2015-07-10 20:29:21 UTC) #3
enne (OOO)
5 years, 5 months ago (2015-07-10 20:29:22 UTC) #4
ajuma
https://codereview.chromium.org/1232573005/diff/1/cc/layers/layer.cc File cc/layers/layer.cc (right): https://codereview.chromium.org/1232573005/diff/1/cc/layers/layer.cc#newcode138 cc/layers/layer.cc:138: DCHECK(!host->in_update()); On 2015/07/10 20:29:21, enne wrote: > Reuse host->in_paint_layer_contents()? ...
5 years, 5 months ago (2015-07-10 20:52:53 UTC) #5
enne (OOO)
lgtm
5 years, 5 months ago (2015-07-10 21:01:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232573005/20001
5 years, 5 months ago (2015-07-10 22:33:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 22:37:50 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 22:39:50 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b92d0faeb76efa29112da48ed7a193827d62017
Cr-Commit-Position: refs/heads/master@{#338385}

Powered by Google App Engine
This is Rietveld 408576698