chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc - Issue 1232553003: Add new certificateProvider extension API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

Issue 1232553003: Add new certificateProvider extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/certificate_provider/certificate_provider_service.h ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

index f6e6cd75a47b6c53a89eebb10f6bd18b7e1f983c..da19c82e8540c127f5d652fe4c32a1752626ff2e 100644

--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

@@ -444,7 +444,7 @@ void CertificateProviderService::RequestSignatureFromExtension(

const int sign_request_id = sign_requests_.AddRequest(extension_id, callback);

if (!delegate_->DispatchSignRequestToExtension(extension_id, sign_request_id,

- hash, digest)) {

+ hash, certificate, digest)) {

sign_requests_.RemoveRequest(extension_id, sign_request_id,

nullptr /* callback */);

callback.Run(net::ERR_FAILED, std::vector<uint8_t>());