Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1232543005: Revert of Revert of Clang on Windows: Remove -Wno-unused-variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-unused-variables
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | remoting/remoting_host_win.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 "-Qunused-arguments", # http://crbug.com/504658 801 "-Qunused-arguments", # http://crbug.com/504658
802 "-Wno-extra-tokens", # http://crbug.com/504663 802 "-Wno-extra-tokens", # http://crbug.com/504663
803 "-Wno-microsoft", # http://crbug.com/505296 803 "-Wno-microsoft", # http://crbug.com/505296
804 "-Wno-missing-braces", # http://crbug.com/505297 804 "-Wno-missing-braces", # http://crbug.com/505297
805 "-Wno-pointer-sign", # http://crbug.com/505303 805 "-Wno-pointer-sign", # http://crbug.com/505303
806 "-Wno-switch", # http://crbug.com/505308 806 "-Wno-switch", # http://crbug.com/505308
807 "-Wno-unknown-pragmas", # http://crbug.com/505314 807 "-Wno-unknown-pragmas", # http://crbug.com/505314
808 "-Wno-unused-function", # http://crbug.com/505316 808 "-Wno-unused-function", # http://crbug.com/505316
809 "-Wno-unused-private-field", # http://crbug.com/505317 809 "-Wno-unused-private-field", # http://crbug.com/505317
810 "-Wno-unused-value", # http://crbug.com/505318 810 "-Wno-unused-value", # http://crbug.com/505318
811 "-Wno-unused-variable", # http://crbug.com/505319
812 "-Wno-unused-local-typedef", # http://crbug.com/411648 811 "-Wno-unused-local-typedef", # http://crbug.com/411648
813 ] 812 ]
814 } 813 }
815 } else { 814 } else {
816 # Common GCC warning setup. 815 # Common GCC warning setup.
817 default_warning_flags += [ 816 default_warning_flags += [
818 # Enables. 817 # Enables.
819 "-Wendif-labels", # Weird old-style text after an #endif. 818 "-Wendif-labels", # Weird old-style text after an #endif.
820 "-Werror", # Warnings as errors. 819 "-Werror", # Warnings as errors.
821 820
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
998 # not support this option, since they are usually using gcc 4.2.1, which 997 # not support this option, since they are usually using gcc 4.2.1, which
999 # does not have this flag yet. 998 # does not have this flag yet.
1000 cflags += [ "-Wno-unused-result" ] 999 cflags += [ "-Wno-unused-result" ]
1001 } 1000 }
1002 1001
1003 if (is_clang) { 1002 if (is_clang) {
1004 cflags += [ 1003 cflags += [
1005 # TODO(mgiuca): Move this suppression into individual third-party 1004 # TODO(mgiuca): Move this suppression into individual third-party
1006 # libraries as required. http://crbug.com/505301. 1005 # libraries as required. http://crbug.com/505301.
1007 "-Wno-overloaded-virtual", 1006 "-Wno-overloaded-virtual",
1007
1008 # Lots of third-party libraries have unused variables. Instead of
1009 # suppressing them individually, we just blanket suppress them here.
1010 "-Wno-unused-variable",
1008 ] 1011 ]
1009 } 1012 }
1010 1013
1011 if (is_linux || is_android) { 1014 if (is_linux || is_android) {
1012 cflags += [ 1015 cflags += [
1013 # Don't warn about printf format problems. This is off by default in gcc 1016 # Don't warn about printf format problems. This is off by default in gcc
1014 # but on in Ubuntu's gcc(!). 1017 # but on in Ubuntu's gcc(!).
1015 "-Wno-format", 1018 "-Wno-format",
1016 ] 1019 ]
1017 cflags_cc += [ 1020 cflags_cc += [
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
1245 cflags += [ "-gsplit-dwarf" ] 1248 cflags += [ "-gsplit-dwarf" ]
1246 } 1249 }
1247 } 1250 }
1248 } 1251 }
1249 1252
1250 config("no_symbols") { 1253 config("no_symbols") {
1251 if (!is_win) { 1254 if (!is_win) {
1252 cflags = [ "-g0" ] 1255 cflags = [ "-g0" ]
1253 } 1256 }
1254 } 1257 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | remoting/remoting_host_win.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698