Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1232483003: Change MIPS to avoid "none-nacl" for unsandboxed tests (Closed)

Created:
5 years, 5 months ago by rkotlerimgtec
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change MIPS to avoid "none-nacl" for unsandboxed tests. This changes the run-pnacl-sz script to be more consistent with the other targets. BUG=https://code.google.com/p/nativeclient/issues/detail?id=4167 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e105c74bee81d9526651cf31d3dec6c955351334

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M pydir/run-pnacl-sz.py View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/function_aligned.ll View 2 chunks +4 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
reed.kotler
Address issues from https://codereview.chromium.org/1176133004/ regarding none-nacl .
5 years, 5 months ago (2015-07-09 23:53:40 UTC) #2
jvoung (off chromium)
LGTM thanks I noticed you changed emails to rkotlerimgtec@gmail.com, but that account has also signed ...
5 years, 5 months ago (2015-07-10 00:02:04 UTC) #3
reed.kotler
On 2015/07/10 00:02:04, jvoung wrote: > LGTM thanks > > I noticed you changed emails ...
5 years, 5 months ago (2015-07-10 00:08:02 UTC) #4
jvoung (off chromium)
On 2015/07/10 00:08:02, reed.kotler wrote: > On 2015/07/10 00:02:04, jvoung wrote: > > LGTM thanks ...
5 years, 5 months ago (2015-07-10 21:05:35 UTC) #5
reed.kotler
You can go ahead and commit it. I don't think I meant to end up ...
5 years, 5 months ago (2015-07-10 21:35:36 UTC) #6
jvoung (off chromium)
5 years, 5 months ago (2015-07-10 21:53:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e105c74bee81d9526651cf31d3dec6c955351334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698