Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1232483002: rename sky_apk to sky_dev (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sky/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 23:26:36 UTC) #2
jackson
Committed patchset #1 (id:1) manually as 575ac08841512ef19b8b3dd31b081e92a290067c (presubmit successful).
5 years, 5 months ago (2015-07-09 23:26:51 UTC) #3
Chinmay
5 years, 5 months ago (2015-07-09 23:28:08 UTC) #4
Message was sent while issue was closed.
On 2015/07/09 at 23:26:51, jackson wrote:
> Committed patchset #1 (id:1) manually as
575ac08841512ef19b8b3dd31b081e92a290067c (presubmit successful).

There is a "//sky:sky_apk" in the root BUILD.gn for iOS too :(

Powered by Google App Engine
This is Rietveld 408576698