Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1232473003: Delete AnimationValue (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Matt Perry
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete AnimationValue Please use AnimationType and AnimationPerformance instead. R=mpcomplete@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a064d1198d781c52afeb24d2130a08d940beb928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -186 lines) Patch
M sky/sdk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D sky/sdk/lib/animation/animated_value.dart View 1 chunk +0 lines, -84 lines 0 comments Download
M sky/sdk/lib/animation/animation_performance.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/animation/generators.dart View 1 chunk +0 lines, -65 lines 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 2 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-10 03:50:18 UTC) #1
Matt Perry
lgtm
5 years, 5 months ago (2015-07-10 17:09:25 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-10 17:25:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a064d1198d781c52afeb24d2130a08d940beb928 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698