Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 123243002: Replace WebNonCopyable with DISALLOW_COPY_AND_ASSIGN in test runner library (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 11 months ago
Reviewers:
battre
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Replace WebNonCopyable with DISALLOW_COPY_AND_ASSIGN in test runner library BUG=331298 R=battre@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242873

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -53 lines) Patch
M content/shell/renderer/test_runner/CppBoundClass.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockColorChooser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockSpellCheck.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebAudioDevice.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebMIDIAccessor.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebMediaStreamCenter.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCDTMFSenderHandler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCDataChannelHandler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebRTCPeerConnectionHandler.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebSpeechInputController.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebSpeechRecognizer.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/NotificationPresenter.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/SpellCheckClient.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/TestInterfaces.h View 3 chunks +4 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebFrameTestProxy.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebPermissions.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.h View 3 chunks +6 lines, -12 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestThemeControlWin.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestThemeEngineMac.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestThemeEngineWin.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/WebUserMediaClientMock.h View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-02 16:29:13 UTC) #1
battre
lgtm
6 years, 11 months ago (2014-01-02 16:32:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/123243002/1
6 years, 11 months ago (2014-01-02 16:34:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-02 21:25:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/123243002/360001
6 years, 11 months ago (2014-01-03 08:45:23 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) chromedriver2_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=209482
6 years, 11 months ago (2014-01-03 09:30:57 UTC) #6
jochen (gone - plz use gerrit)
6 years, 11 months ago (2014-01-03 09:52:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r242873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698