Trivial code style changes in animation code.

Trivial code style changes in animation code.

R=mpcomplete@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ab109763ab55b26dfb385f69cb2feb4ff852c377

[Matt Perry, 2015-07-13 17:32:55]

mpcomplete@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2015-07-13 17:32:55]

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/animati...
File sky/sdk/lib/widgets/animation_builder.dart (right):

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/animati...
sky/sdk/lib/widgets/animation_builder.dart:83: return; // TODO(mpcomplete):
Should we handle transition from null?
google C++ style is to have 2 spaces before in-line comments. dunno about dart
style

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
sky/sdk/lib/widgets/material.dart:42: final AnimationBuilder _builder = new
AnimationBuilder();
Wouldn't this cause us to allocate a new object for Materials that we're going
to throw away?

[abarth-chromium, 2015-07-13 17:41:06]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-07-13 17:41:07]

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
sky/sdk/lib/widgets/material.dart:42: final AnimationBuilder _builder = new
AnimationBuilder();
On 2015/07/13 at 17:32:55, Matt Perry wrote:
> Wouldn't this cause us to allocate a new object for Materials that we're going
to throw away?

Constructors for final fields are called lazily the first time someone reads
them.

[jackson, 2015-07-13 17:43:30]

jackson@google.com changed reviewers:
+ jackson@google.com

[jackson, 2015-07-13 17:43:30]

lgtm

[abarth-chromium, 2015-07-13 17:44:58]

abarth@chromium.org changed reviewers:
- jackson@google.com

[abarth-chromium, 2015-07-13 17:44:59]

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
File sky/sdk/lib/widgets/material.dart (right):

https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/materia...
sky/sdk/lib/widgets/material.dart:42: final AnimationBuilder _builder = new
AnimationBuilder();
On 2015/07/13 at 17:41:06, abarth-chromium wrote:
> On 2015/07/13 at 17:32:55, Matt Perry wrote:
> > Wouldn't this cause us to allocate a new object for Materials that we're
going to throw away?
> 
> Constructors for final fields are called lazily the first time someone reads
them.

s/Constructors/initializers/

[Matt Perry, 2015-07-13 17:49:06]

lgtm

[Hixie, 2015-07-13 18:05:02]

On 2015/07/13 at 17:32:55, mpcomplete wrote:
>
https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/animati...
> File sky/sdk/lib/widgets/animation_builder.dart (right):
> 
>
https://codereview.chromium.org/1232403004/diff/1/sky/sdk/lib/widgets/animati...
> sky/sdk/lib/widgets/animation_builder.dart:83: return; // TODO(mpcomplete):
Should we handle transition from null?
> google C++ style is to have 2 spaces before in-line comments. dunno about dart
style

We use one space everywhere currently.

[Hixie, 2015-07-13 18:11:24]

Committed patchset #1 (id:1) manually as
ab109763ab55b26dfb385f69cb2feb4ff852c377 (presubmit successful).